Rebuilt Bolivia countryData and added a test for the postal code handler function#697
Open
kaio-donadelli wants to merge 9 commits into
Open
Rebuilt Bolivia countryData and added a test for the postal code handler function#697kaio-donadelli wants to merge 9 commits into
kaio-donadelli wants to merge 9 commits into
Conversation
Contributor
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
…r the postal code handler function.
kaio-donadelli
force-pushed
the
l10n_fix-BOL
branch
from
4e33f8a to
ab5f270
Compare
4 tasks
fdaciuk
requested changes
Jun 18, 2026
Correct Tarija Avilez OEP codes, make the handler immutable and strict-safe, harden geolocation test helpers, and exclude helpers from Jest discovery. Co-authored-by: Cursor <cursoragent@cursor.com>
🛡️ SDD Check — action requiredI couldn't detect an SDD in this PR. Please check one option below (requires write access to the repo):
|
Lurian
approved these changes
Jul 1, 2026
fdaciuk
requested changes
Jul 1, 2026
fdaciuk
left a comment
fdaciuk
left a comment
There was a problem hiding this comment.
Achados que valem correção antes do merge: tipagem quebrada no novo helper de teste, escopo do teste genérico demais e duplicação de lógica do handler entre países.
Migrate BOL, COL, CRI, PER, and CHL to createPostalCodeFromHierarchyHandler with immutable postal code resolution from administrative hierarchy. Co-authored-by: Cursor <cursoragent@cursor.com>
Export typed postal code hierarchy maps from postalCodes transform and reference them directly in PostalCodeRules instead of ReturnType inference. Co-authored-by: Cursor <cursoragent@cursor.com>
Scope integration tests to Bolivia only and remove cross-country discovery helpers so unrelated country changes cannot break this PR's test suite. Co-authored-by: Cursor <cursoragent@cursor.com>
Search explicitly for two administrative paths whose postal codes differ instead of assuming the first municipality of two provinces always differs. Co-authored-by: Cursor <cursoragent@cursor.com>
fdaciuk
requested changes
Jul 1, 2026
fdaciuk
left a comment
fdaciuk
left a comment
There was a problem hiding this comment.
Threads anteriores resolvidos e confirmados. Restam 3 pontos novos encontrados nesta rodada, um deles quebrando tsc --noEmit.
Fixes tsc TS2322 by avoiding keyof AddressWithValidation assignment. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace manual nested traversal with lodash/get, matching AddressContainer. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace conditional test registration with expect(alternateSample).not.toBeNull(). Co-authored-by: Cursor <cursoragent@cursor.com>
|
0 New Issues
7 Fixed Issues
0 Accepted Issues
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fix missing and incorrect Bolivia postal code and location data using INE 2024 Census sources, and ensure geolocation resolves the correct 5-digit postal code from the department → province → municipality hierarchy.
Summary
BOLcountry data (BOL.json+BOL.ts) from INE 2024createPostalCodeFromHierarchyHandler; migrated BOL, COL, CRI, PER, CHLPostalCodeRulesTypes of changes
Related