Fixed Product brand logo link#1138
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
vmourac-vtex
left a comment
There was a problem hiding this comment.
Hi @mihaidanieldumitru thanks for the PR
Can you please update the PR description to the suggested template format?
It is very important to include the workspaces before and after the change and, in your case, dedicated links where a 404 is occurring
fc37b02 to
2b1fdee
Compare
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
When you have a Brand Logo with Link it goes to incorrect link
/${slug}/band lands in a 404 page. The correct link should be/${slug}How to test it?
Workspace Before
Workspace After
Screenshots or example usage:
Before Image
After Image
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
