Skip to content

Fixed Product brand logo link#1138

Merged
vsseixaso merged 1 commit intovtex-apps:masterfrom
iviteb:fix/product-brand-logo-link
Aug 13, 2025
Merged

Fixed Product brand logo link#1138
vsseixaso merged 1 commit intovtex-apps:masterfrom
iviteb:fix/product-brand-logo-link

Conversation

@mihaidanieldumitru
Copy link
Copy Markdown
Contributor

@mihaidanieldumitru mihaidanieldumitru commented Jul 1, 2025

What problem is this solving?

When you have a Brand Logo with Link it goes to incorrect link /${slug}/b and lands in a 404 page. The correct link should be /${slug}

How to test it?

Workspace Before
Workspace After

Screenshots or example usage:

Before Image

image

After Image

image

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@vtex-io-ci-cd
Copy link
Copy Markdown
Contributor

vtex-io-ci-cd Bot commented Jul 1, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link
Copy Markdown

vtex-io-docs-bot Bot commented Jul 1, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Copy Markdown
Contributor

@vmourac-vtex vmourac-vtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mihaidanieldumitru thanks for the PR
Can you please update the PR description to the suggested template format?

It is very important to include the workspaces before and after the change and, in your case, dedicated links where a 404 is occurring

@mihaidanieldumitru mihaidanieldumitru force-pushed the fix/product-brand-logo-link branch from fc37b02 to 2b1fdee Compare July 23, 2025 15:19
Copy link
Copy Markdown
Contributor

@vsseixaso vsseixaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@vsseixaso vsseixaso merged commit 4350ee2 into vtex-apps:master Aug 13, 2025
4 of 5 checks passed
@vtex-io-ci-cd
Copy link
Copy Markdown
Contributor

vtex-io-ci-cd Bot commented Aug 13, 2025

Your PR has been merged! App is being published. 🚀
Version 3.178.2 → 3.178.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-components@3.178.3

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants