[STR-985] Fix: Allow only Admin users to access certain APIs#104
Open
mendescamara wants to merge 9 commits intomasterfrom
Open
[STR-985] Fix: Allow only Admin users to access certain APIs#104mendescamara wants to merge 9 commits intomasterfrom
mendescamara wants to merge 9 commits intomasterfrom
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch strengthens admin user validation in the VTEX service layer, adds automated unit tests, fixes the .NET build when the test project lives under the same
dotnet/folder as the app, and runs .NET tests in the Quality Engineering GitHub Actions workflow.NOTE: I am still analyzing the logs to confirm the impact of this change on the APIs.
Changes
Authentication and License Manager (
VtexAPIService)credential/validate, the flow calls the private accounts API/api/pvt/accounts/{account}/logins/{userId}/grantedto confirm the login is granted in License Manager.false(denied access), as well astrueand JSON boolean forms, instead of relying on HTTP status alone.Id, the user is not treated as valid for the LM check.Unit tests
AvailabilityNotify.Testsproject (xUnit + Moq) with tests focused onVtexAPIService(ValidateUserToken,IsValidAuthUser,ListNotifyRequests) and a testHttpMessageHandlerto stub outbound HTTP calls.dotnet/dotnet.slngroups the app and the test project for restore, build, and test from thedotnet/directory.Build and NuGet
availability-notify.csproj,DefaultItemExcludesforAvailabilityNotify.Tests/**so the SDK default glob does not compile test sources into the main assembly (typical cause of CS0246 forMoq/Xuniton the wrong project).NuGet.Configpinningnuget.orgfor reliable restore when machine-level feeds or credential providers fail.CI (GitHub Actions)
The tests are not yet in GitHub Actions because I don't have permission to modify the .github/workflows files.
I have requested permission from the IT team.
How to verify locally
dotnet restore dotnet build dotnet/availability-notify.csproj dotnet test dotnet/AvailabilityNotify.Tests/AvailabilityNotify.Tests.csproj(Adjust paths if you use a different
.slnat the repo root or underdotnet/.)Checklist