-
Notifications
You must be signed in to change notification settings - Fork 45
Draft: VRMC_springBone_limit
#496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
0b5vr
wants to merge
14
commits into
vrm-c:master
Choose a base branch
from
0b5vr:springBone-limit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
20f19c8
feat: The first draft of `VRMC_springBone_limit`
0b5vr 82c1c0d
feat: `VRMC_springBone_limit`, swap phi and theta
0b5vr 029c53b
feat: `VRMC_springBone_limit`, update details of rotation and applica…
0b5vr 97fdf66
feat: `VRMC_springBone_limit`, fix example JSON
0b5vr 0ff4bb4
docs: VRMC_springBone_limit, remove a TODO
0b5vr 3d7f37b
feat: `VRMC_springBone_limit`, add reference implementation
0b5vr 9e98e83
docs: `VRMC_springBone_limit`, update `tailDir` description for clari…
0b5vr 04b0db9
docs: `VRMC_springBone_limit`, add explanation for `boneAxis` in the …
0b5vr 1a14366
docs: `VRMC_springBone_limit`, update pseudocode to reference `limit`…
0b5vr 0003d61
docs: `VRMC_springBone_limit` clarify the timing to apply limits in t…
0b5vr 11cb6fd
docs: `VRMC_springBone_limit`, clarify the meaning of parameter angle…
0b5vr c8a74ad
feat: NORMATIVE CHANGE to draft springBone limit spec, change spheric…
0b5vr 2c871d4
feat: NORMATIVE CHANGE to draft springBone limit spec, make it rotate…
0b5vr 75fbd48
fix: springBone_limit, Fix pseudocode of rotation
0b5vr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # VRMC_springBone_limit-1.0 | ||
|
|
||
| *Version 1.0-draft* | ||
|
|
||
| TODO → [README.ja.md](README.ja.md) |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+195 KB
specification/VRMC_springBone_limit-1.0/figures/spherical-limit-pitch-yaw.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
27 changes: 27 additions & 0 deletions
27
specification/VRMC_springBone_limit-1.0/schema/VRMC_springBone_limit.coneLimit.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema", | ||
| "title": "ConeLimit", | ||
| "type": "object", | ||
| "description": "A limit that restricts the orientation of the spring in a cone shape.", | ||
| "allOf": [ { "$ref": "glTFProperty.schema.json" } ], | ||
| "properties": { | ||
| "angle": { | ||
| "type": "number", | ||
| "description": "The angle of the cone limit in radians. If the angle is set to π or greater, the angle will be interpreted as π by the implementation. When the angle is set to π, the cone shape becomes a sphere.", | ||
| "minimum": 0.0 | ||
| }, | ||
| "rotation": { | ||
| "type": "array", | ||
| "description": "The rotation from the default orientation of the cone limit. The rotation is represented as a quaternion (x, y, z, w), where w is the scalar.", | ||
| "items": { | ||
| "type": "number", | ||
| "minimum": -1.0, | ||
| "maximum": 1.0 | ||
| }, | ||
| "minItems": 4, | ||
| "maxItems": 4, | ||
| "default": [ 0.0, 0.0, 0.0, 1.0 ] | ||
| } | ||
| }, | ||
| "required": [ "angle" ] | ||
| } |
27 changes: 27 additions & 0 deletions
27
specification/VRMC_springBone_limit-1.0/schema/VRMC_springBone_limit.hingeLimit.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema", | ||
| "title": "HingeLimit", | ||
| "type": "object", | ||
| "description": "A limit that restricts the orientation of the spring in a hinge shape.", | ||
| "allOf": [ { "$ref": "glTFProperty.schema.json" } ], | ||
| "properties": { | ||
| "angle": { | ||
| "type": "number", | ||
| "description": "The angle of the hinge limit in radians. If the angle is set to π or greater, the angle will be interpreted as π by the implementation. When the angle is set to π, the hinge shape becomes a full disc.", | ||
| "minimum": 0.0 | ||
| }, | ||
| "rotation": { | ||
| "type": "array", | ||
| "description": "The rotation from the default orientation of the hinge limit. The rotation is represented as a quaternion (x, y, z, w), where w is the scalar.", | ||
| "items": { | ||
| "type": "number", | ||
| "minimum": -1.0, | ||
| "maximum": 1.0 | ||
| }, | ||
| "minItems": 4, | ||
| "maxItems": 4, | ||
| "default": [ 0.0, 0.0, 0.0, 1.0 ] | ||
| } | ||
| }, | ||
| "required": [ "angle" ] | ||
| } |
25 changes: 25 additions & 0 deletions
25
specification/VRMC_springBone_limit-1.0/schema/VRMC_springBone_limit.limit.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema", | ||
| "title": "Limit", | ||
| "type": "object", | ||
| "description": "Describes a limit apply to the spring. Either cone, hinge, or spherical must be present.", | ||
| "allOf": [ { "$ref": "glTFProperty.schema.json" } ], | ||
| "properties": { | ||
| "cone": { | ||
| "$ref": "VRMC_springBone_limit.coneLimit.schema.json" | ||
| }, | ||
| "hinge": { | ||
| "$ref": "VRMC_springBone_limit.hingeLimit.schema.json" | ||
| }, | ||
| "spherical": { | ||
| "$ref": "VRMC_springBone_limit.sphericalLimit.schema.json" | ||
| }, | ||
| "extensions": { }, | ||
| "extras": { } | ||
| }, | ||
| "oneOf": [ | ||
| { "required": [ "cone" ] }, | ||
| { "required": [ "hinge" ] }, | ||
| { "required": [ "spherical" ] } | ||
| ] | ||
| } |
19 changes: 19 additions & 0 deletions
19
specification/VRMC_springBone_limit-1.0/schema/VRMC_springBone_limit.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema", | ||
| "title": "VRMC_springBone_limit", | ||
| "type": "object", | ||
| "description": "An angle limit for VRMC_springBone.", | ||
| "allOf": [ { "$ref": "glTFProperty.schema.json" } ], | ||
| "properties": { | ||
| "specVersion": { | ||
| "type": "string", | ||
| "description": "Specification version of VRMC_springBone_limit." | ||
| }, | ||
| "limit": { | ||
| "$ref": "VRMC_springBone_limit.limit.schema.json" | ||
| }, | ||
| "extensions": { }, | ||
| "extras": { } | ||
| }, | ||
| "required": [ "specVersion", "limit" ] | ||
| } |
32 changes: 32 additions & 0 deletions
32
...ication/VRMC_springBone_limit-1.0/schema/VRMC_springBone_limit.sphericalLimit.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "$schema": "http://json-schema.org/draft-04/schema", | ||
| "title": "SphericalLimit", | ||
| "type": "object", | ||
| "description": "A limit that restricts the orientation of the spring in a spherical coordinate shape.", | ||
| "allOf": [ { "$ref": "glTFProperty.schema.json" } ], | ||
| "properties": { | ||
| "pitch": { | ||
| "type": "number", | ||
| "description": "The pitch angle of the spherical limit in radians. If the pitch angle is set to π or greater, the angle will be interpreted as π by the implementation.", | ||
| "minimum": 0.0 | ||
| }, | ||
| "yaw": { | ||
| "type": "number", | ||
| "description": "The yaw angle of the spherical limit in radians. If the yaw angle is set to π/2 or greater, the angle will be interpreted as π/2 by the implementation.", | ||
| "minimum": 0.0 | ||
| }, | ||
| "rotation": { | ||
| "type": "array", | ||
| "description": "The rotation from the default orientation of the spherical limit. The rotation is represented as a quaternion (x, y, z, w), where w is the scalar.", | ||
| "items": { | ||
| "type": "number", | ||
| "minimum": -1.0, | ||
| "maximum": 1.0 | ||
| }, | ||
| "minItems": 4, | ||
| "maxItems": 4, | ||
| "default": [ 0.0, 0.0, 0.0, 1.0 ] | ||
| } | ||
| }, | ||
| "required": [ "pitch", "yaw" ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 limit 空間の x軸回転が pitch