[VRMC_springBone_limit] fix editor ui - #2834
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the VRM 1.0 SpringBone AngleLimit inspector UX to better reflect the current draft spec and reduce user confusion around limit settings (per issue #2831).
Changes:
- Update the AngleLimit foldout label and remove outdated “import/export not implemented” messaging.
- Clarify Cone/Hinge limit UI by labeling
m_pitchas “Angle”, and add a warning for end-of-chain (last tail) joints. - Add constructor parameter documentation notes for AngleLimit fields in
BlittableJointMutable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Packages/VRM10/Editor/Components/SpringBone/VRM10SpringBoneJointEditor.cs | Adjusts AngleLimit inspector labeling/warnings and removes outdated HelpBox text. |
| Packages/UniGLTF/Runtime/SpringBoneJobs/Blittables/BlittableJointMutable.cs | Adds documentation notes clarifying AngleLimit parameter meaning. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if (isLastTail) | ||
| { | ||
| case UniGLTF.SpringBoneJobs.AnglelimitTypes.None: | ||
| break; | ||
|
|
||
| case UniGLTF.SpringBoneJobs.AnglelimitTypes.Cone: | ||
| EditorGUILayout.PropertyField(m_angleLimitRotation); | ||
| EditorGUILayout.PropertyField(m_angleLimitPitch); | ||
| break; | ||
|
|
||
| case UniGLTF.SpringBoneJobs.AnglelimitTypes.Hinge: | ||
| EditorGUILayout.PropertyField(m_angleLimitRotation); | ||
| EditorGUILayout.PropertyField(m_angleLimitPitch); | ||
| break; | ||
|
|
||
| case UniGLTF.SpringBoneJobs.AnglelimitTypes.Spherical: | ||
| EditorGUILayout.PropertyField(m_angleLimitRotation); | ||
| EditorGUILayout.PropertyField(m_angleLimitPitch); | ||
| EditorGUILayout.PropertyField(m_angleLimitYaw); | ||
| break; | ||
| EditorGUILayout.HelpBox("末端ノードでは無効です。", MessageType.Warning); | ||
| } |
There was a problem hiding this comment.
MAY: "末端ノードではAngleLimitは無視されます。" と明確に書いてあげたほうが親切かも。また、設定をコピーして回るときに毎回Noneに変えるのも面倒なので、WarningでなくInfoで良いかも。
There was a problem hiding this comment.
MUST: isLastTail が true のときにTypeを変更するUIが表示されなくなるのはCopilotの指摘通り。これは修正するべきです。
| /// <param name="angleLimit1">pitch when Spherical</param> | ||
| /// <param name="angleLimit2">yaw when Spherical</param> |
| if (m_showAnglelimitSettings) | ||
| { | ||
| EditorGUILayout.HelpBox("SpringBoneの角度制限はまだdraft仕様です。将来的に仕様が変更される可能性があります。また、VRMファイルへのインポート・エクスポート機能はまだ実装されていません。\nThe angle limit feature for SpringBone is still in draft status. The specifications may change in the future. Also, the import/export of VRM files has not yet been implemented.", MessageType.Warning); | ||
| EditorGUILayout.HelpBox("SpringBoneの角度制限はまだdraft仕様です。将来的に仕様が変更される可能性があります。\nThe angle limit feature for SpringBone is still in draft status. The specifications may change in the future.", MessageType.Warning); |
Add jointsについて、これは |
0b5vr
left a comment
There was a problem hiding this comment.
兼ねCopilotの指摘に同意します。詳細は各コメントを参照ください。
fixed #2831
は、良くわからなかったので特に作業していません。