UI improvements for the Spring Bone Editor#2806
Merged
Merged
Conversation
Contributor
Author
Vrm10Instance の Inspector から |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Spring Bone editing workflow by moving SpringBone “Springs” and “ColliderGroups” editing out of the Vrm10Instance inspector into dedicated EditorWindows, with associated scene visualization updates.
Changes:
- Replaces the previous in-inspector SpringBone UI (tabs/ListView) with buttons that open new dedicated windows.
- Adds
Vrm10SpringsWindowandVrm10ColliderGroupsWindowfor editing and scene visualization. - Adjusts gizmo/scene drawing behavior for colliders and collider groups to better fit the new workflow.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Packages/VRM10/Runtime/Components/SpringBone/VRM10SpringBoneColliderGroup.cs | Removes collider-group-selected gizmo drawing from the runtime component. |
| Packages/VRM10/Runtime/Components/SpringBone/VRM10SpringBoneCollider.cs | Adds a static flag to suppress collider gizmos while the collider-groups window is active. |
| Packages/VRM10/Editor/Vrm10InstanceEditor.cs | Replaces SpringBone inspector UI with buttons that open the new windows. |
| Packages/VRM10/Editor/EditorWindow/Vrm10SpringsWindow.cs.meta | Adds Unity meta for the new Springs window script. |
| Packages/VRM10/Editor/EditorWindow/Vrm10SpringsWindow.cs | New EditorWindow to edit Springs and draw selected spring joint connections in SceneView. |
| Packages/VRM10/Editor/EditorWindow/Vrm10ColliderGroupsWindow.cs.meta | Adds Unity meta for the new ColliderGroups window script. |
| Packages/VRM10/Editor/EditorWindow/Vrm10ColliderGroupsWindow.cs | New EditorWindow to edit ColliderGroups and draw collider gizmos in SceneView. |
| Packages/VRM10/Editor/EditorWindow.meta | Adds Unity folder meta for the new EditorWindow directory. |
Files not reviewed (3)
- Packages/VRM10/Editor/EditorWindow.meta: Generated file
- Packages/VRM10/Editor/EditorWindow/Vrm10ColliderGroupsWindow.cs.meta: Generated file
- Packages/VRM10/Editor/EditorWindow/Vrm10SpringsWindow.cs.meta: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
notargs
requested changes
Jun 30, 2026
notargs
left a comment
notargs
left a comment
Contributor
There was a problem hiding this comment.
大まかには問題なさそうです。コメントした点と、Copilotがレビューしている点について確認お願いします～ 🙇
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #2799