Skip to content

[expression] NodeTransform を追加#2771

Merged
ousttrue merged 14 commits into
vrm-c:masterfrom
ousttrue:feature/bone_morph
Apr 13, 2026
Merged

[expression] NodeTransform を追加#2771
ousttrue merged 14 commits into
vrm-c:masterfrom
ousttrue:feature/bone_morph

Conversation

@ousttrue

@ousttrue ousttrue commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

仕様案

vrm-c/vrm-specification#507

import / export / 最低限のEditor を実装

@ousttrue

ousttrue commented Feb 9, 2026

Copy link
Copy Markdown
Contributor Author

bone_morph_preview

list の4つ目 NodeTransform が増えた

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

VRM10 の Expression に「VRMC_vrm_expressions_node_transform」拡張(NodeTransform バインド)を追加し、import/export と最小限の Editor/Preview・Runtime 適用経路まで通す PR です。

Changes:

  • Expression の拡張 VRMC_vrm_expressions_node_transform のフォーマット(Serializer/Deserializer/Format)を追加
  • Importer/Exporter で NodeTransformBindings の読み書きを追加
  • Runtime の Expression 適用に NodeTransform のマージ処理を追加し、Editor プレビュー UI に NodeTransform の編集を追加

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
Packages/VRM10/Tests/VRM10.Tests.asmdef テストアセンブリ参照 GUID の更新
Packages/VRM10/Runtime/IO/Vrm10Importer.cs Expression import 時に node transform 拡張を取り込み
Packages/VRM10/Runtime/IO/Vrm10Exporter.cs Expression export 時に node transform 拡張を出力
Packages/VRM10/Runtime/IO/ExpressionExtensions.cs NodeTransformBind → NodeTransformBinding 変換を追加
Packages/VRM10/Runtime/Format/SpringBoneLimit/Format.g.cs コメント文言の修正(phi/theta → pitch/yaw)
Packages/VRM10/Runtime/Format/ExpressionsNodeTransform.meta 新規フォルダ meta
Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Format.g.cs node transform 拡張の generated format 定義
Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Format.g.cs.meta 上記 meta
Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Serializer.g.cs node transform 拡張の generated serializer
Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Serializer.g.cs.meta 上記 meta
Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Deserializer.g.cs node transform 拡張の generated deserializer
Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Deserializer.g.cs.meta 上記 meta
Packages/VRM10/Runtime/Components/Vrm10Runtime/Vrm10RuntimeExpression.cs ExpressionMerger へ initPose を渡すよう更新
Packages/VRM10/Runtime/Components/Vrm10Runtime/Vrm10Runtime.cs Vrm10RuntimeExpression 構築に initPose を追加
Packages/VRM10/Runtime/Components/Expression/VRM10Expression.cs NodeTransformBindings を ScriptableObject に追加
Packages/VRM10/Runtime/Components/Expression/Preview/PreviewSceneManager.cs プレビュー Bake に node transform 適用を追加、選択用パスリスト追加
Packages/VRM10/Runtime/Components/Expression/Preview/PreviewMeshItem.cs SkinnedMeshRenderer の bake 用 Mesh を常に持つよう変更
Packages/VRM10/Runtime/Components/Expression/NodeTransformtBinding.cs NodeTransformBinding 構造体と Apply 実装を追加
Packages/VRM10/Runtime/Components/Expression/NodeTransformtBinding.cs.meta 上記 meta
Packages/VRM10/Runtime/Components/Expression/NodeTransformBindingMerger.cs Runtime の node transform 適用(merger)を新規追加
Packages/VRM10/Runtime/Components/Expression/NodeTransformBindingMerger.cs.meta 上記 meta
Packages/VRM10/Runtime/Components/Expression/ExpressionMerger.cs node transform merger を ExpressionMerger に統合
Packages/VRM10/Editor/Vrm10SerializerGenerator.cs schema→generated 出力対象に ExpressionsNodeTransform を追加、出力先定数を整理
Packages/VRM10/Editor/Components/Expression/SerializedExpressionEditor.cs NodeTransform 編集リストを toolbar に追加
Packages/VRM10/Editor/Components/Expression/ReorderableNodeTransformBindingList.cs NodeTransformBindings 編集用 ReorderableList を新規追加
Packages/VRM10/Editor/Components/Expression/ReorderableNodeTransformBindingList.cs.meta 上記 meta
Packages/VRM10/Editor/Components/Expression/PreviewFaceRenderer.cs skinned mesh の BakeMesh を描画前に行う変更
Packages/VRM10/Editor/Components/Expression/ExpressionEditorHelper.cs Vector3 編集用ユーティリティを追加
Comments suppressed due to low confidence (1)

Packages/VRM10/Editor/Components/Expression/PreviewFaceRenderer.cs:120

  • BakeMesh is invoked inside the per-submesh loop, which bakes the same skinned mesh multiple times per render. Bake once per PreviewMeshItem (outside the submesh loop) and then draw all submeshes, to reduce editor preview overhead.
                    int subMeshCount = item.Mesh.subMeshCount;
                    for (int i = 0; i < subMeshCount; i++)
                    {
                        if (item.SkinnedMeshRenderer != null)
                        {
                            item.SkinnedMeshRenderer.BakeMesh(item.Mesh);
                        }
                        m_previewUtility.DrawMesh(item.Mesh,
                            item.Position, item.Rotation,
                            item.Materials[i], i);
                    }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Packages/VRM10/Runtime/Components/Expression/NodeTransformtBinding.cs Outdated
Comment thread Packages/VRM10/Runtime/Components/Expression/ExpressionMerger.cs
Comment thread Packages/VRM10/Runtime/IO/Vrm10Exporter.cs Outdated
Comment thread Packages/VRM10/Runtime/IO/ExpressionExtensions.cs Outdated
Comment thread Packages/VRM10/Runtime/IO/Vrm10Importer.cs Outdated
@ousttrue ousttrue added Expression(BlendShape) BlendShape rename to Expression Non breaking changes labels Feb 19, 2026
ousttrue and others added 11 commits March 24, 2026 14:06
…ding.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nsformBindingList.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ousttrue ousttrue force-pushed the feature/bone_morph branch from 0615592 to 42824e5 Compare March 24, 2026 05:08
ousttrue and others added 2 commits March 24, 2026 14:14
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ousttrue

Copy link
Copy Markdown
Contributor Author

rebase しました

@s-iwaki-d s-iwaki-d requested a review from notargs April 10, 2026 04:59

@notargs notargs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大きな問題はなさそう 👍

@ousttrue ousttrue merged commit 1eefdc5 into vrm-c:master Apr 13, 2026
1 check passed
@ousttrue ousttrue deleted the feature/bone_morph branch April 13, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expression(BlendShape) BlendShape rename to Expression Non breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants