[expression] NodeTransform を追加#2771
Merged
Merged
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
VRM10 の Expression に「VRMC_vrm_expressions_node_transform」拡張(NodeTransform バインド)を追加し、import/export と最小限の Editor/Preview・Runtime 適用経路まで通す PR です。
Changes:
- Expression の拡張
VRMC_vrm_expressions_node_transformのフォーマット(Serializer/Deserializer/Format)を追加 - Importer/Exporter で NodeTransformBindings の読み書きを追加
- Runtime の Expression 適用に NodeTransform のマージ処理を追加し、Editor プレビュー UI に NodeTransform の編集を追加
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| Packages/VRM10/Tests/VRM10.Tests.asmdef | テストアセンブリ参照 GUID の更新 |
| Packages/VRM10/Runtime/IO/Vrm10Importer.cs | Expression import 時に node transform 拡張を取り込み |
| Packages/VRM10/Runtime/IO/Vrm10Exporter.cs | Expression export 時に node transform 拡張を出力 |
| Packages/VRM10/Runtime/IO/ExpressionExtensions.cs | NodeTransformBind → NodeTransformBinding 変換を追加 |
| Packages/VRM10/Runtime/Format/SpringBoneLimit/Format.g.cs | コメント文言の修正(phi/theta → pitch/yaw) |
| Packages/VRM10/Runtime/Format/ExpressionsNodeTransform.meta | 新規フォルダ meta |
| Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Format.g.cs | node transform 拡張の generated format 定義 |
| Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Format.g.cs.meta | 上記 meta |
| Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Serializer.g.cs | node transform 拡張の generated serializer |
| Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Serializer.g.cs.meta | 上記 meta |
| Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Deserializer.g.cs | node transform 拡張の generated deserializer |
| Packages/VRM10/Runtime/Format/ExpressionsNodeTransform/Deserializer.g.cs.meta | 上記 meta |
| Packages/VRM10/Runtime/Components/Vrm10Runtime/Vrm10RuntimeExpression.cs | ExpressionMerger へ initPose を渡すよう更新 |
| Packages/VRM10/Runtime/Components/Vrm10Runtime/Vrm10Runtime.cs | Vrm10RuntimeExpression 構築に initPose を追加 |
| Packages/VRM10/Runtime/Components/Expression/VRM10Expression.cs | NodeTransformBindings を ScriptableObject に追加 |
| Packages/VRM10/Runtime/Components/Expression/Preview/PreviewSceneManager.cs | プレビュー Bake に node transform 適用を追加、選択用パスリスト追加 |
| Packages/VRM10/Runtime/Components/Expression/Preview/PreviewMeshItem.cs | SkinnedMeshRenderer の bake 用 Mesh を常に持つよう変更 |
| Packages/VRM10/Runtime/Components/Expression/NodeTransformtBinding.cs | NodeTransformBinding 構造体と Apply 実装を追加 |
| Packages/VRM10/Runtime/Components/Expression/NodeTransformtBinding.cs.meta | 上記 meta |
| Packages/VRM10/Runtime/Components/Expression/NodeTransformBindingMerger.cs | Runtime の node transform 適用(merger)を新規追加 |
| Packages/VRM10/Runtime/Components/Expression/NodeTransformBindingMerger.cs.meta | 上記 meta |
| Packages/VRM10/Runtime/Components/Expression/ExpressionMerger.cs | node transform merger を ExpressionMerger に統合 |
| Packages/VRM10/Editor/Vrm10SerializerGenerator.cs | schema→generated 出力対象に ExpressionsNodeTransform を追加、出力先定数を整理 |
| Packages/VRM10/Editor/Components/Expression/SerializedExpressionEditor.cs | NodeTransform 編集リストを toolbar に追加 |
| Packages/VRM10/Editor/Components/Expression/ReorderableNodeTransformBindingList.cs | NodeTransformBindings 編集用 ReorderableList を新規追加 |
| Packages/VRM10/Editor/Components/Expression/ReorderableNodeTransformBindingList.cs.meta | 上記 meta |
| Packages/VRM10/Editor/Components/Expression/PreviewFaceRenderer.cs | skinned mesh の BakeMesh を描画前に行う変更 |
| Packages/VRM10/Editor/Components/Expression/ExpressionEditorHelper.cs | Vector3 編集用ユーティリティを追加 |
Comments suppressed due to low confidence (1)
Packages/VRM10/Editor/Components/Expression/PreviewFaceRenderer.cs:120
BakeMeshis invoked inside the per-submesh loop, which bakes the same skinned mesh multiple times per render. Bake once perPreviewMeshItem(outside the submesh loop) and then draw all submeshes, to reduce editor preview overhead.
int subMeshCount = item.Mesh.subMeshCount;
for (int i = 0; i < subMeshCount; i++)
{
if (item.SkinnedMeshRenderer != null)
{
item.SkinnedMeshRenderer.BakeMesh(item.Mesh);
}
m_previewUtility.DrawMesh(item.Mesh,
item.Position, item.Rotation,
item.Materials[i], i);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ding.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nsformBindingList.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
0615592 to
42824e5
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
rebase しました |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

仕様案
vrm-c/vrm-specification#507
import / export / 最低限のEditor を実装