[SpringBoneLimit] 動くようにした#2698
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements angle limit functionality for spring bone joints in VRM10, building on previous work from issue #2696. It adds angle limit types (Cone, Hinge, Spherical) with configurable parameters and integrates them into the spring bone system.
- Added angle limit fields and properties to VRM10SpringBoneJoint
- Updated FastSpringBoneBufferFactory to use the new Blittable property
- Enhanced the editor UI to configure angle limit settings
- Fixed angle limit calculations to properly handle direction and length
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| FastSpringBoneBufferFactory.cs | Simplified joint creation to use the new Blittable property |
| VRM10SpringBoneJoint.cs | Added angle limit configuration fields and Blittable property |
| VRM10SpringBoneJointEditor.cs | Added UI controls for angle limit configuration |
| BlittableJointMutable.cs | Updated parameter names for angle limit properties |
| Anglelimit.cs | Fixed angle limit calculations to normalize direction and apply length |
notargs
requested changes
Aug 6, 2025
notargs
left a comment
notargs
left a comment
Contributor
There was a problem hiding this comment.
大まかには問題なさそうです。Copilotくんが指摘しているところだけ修正お願いします 🙏
…t.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Editor.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
typo 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2696 の続き