[model] add least squares solver (review & merge)#6
Open
ryanhammonds wants to merge 3 commits intomainfrom
Open
[model] add least squares solver (review & merge)#6ryanhammonds wants to merge 3 commits intomainfrom
ryanhammonds wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #5. I made this because I was applying this package to 2d spectrograms and needed a faster solver. Allows directly solving conv weights as a linear system, rather than using iterative optimization. This should be faster than convolutional.
Additionally:
dilationkwarg was added that allows the expansion/dilation of the kernel to account for learn weights at various spatial scales, e.g.dilation=2constructs a linear system from sliding the following kernel over an input:equidistantkwarg was added that allows the removal of weight constraints whenFalse. This is for cases when the symmetry assumption is violated.To-Do Before Merging