Conversation
|
Maybe the changes in #27 were unintentional? |
| # } | ||
| # | ||
| define cron::daily ( | ||
| define cron::job::daily ( |
There was a problem hiding this comment.
This would be a breaking change for users who aren't using hiera but defining cron::daily resources directly in their manifests.
|
@mterzo Thanks for finding and reporting this though! |
|
May very well have been. The commit message mentioned puppet4 compliance, which was why I made the assumption they were moved under job. Yeah, I was aware if someone was using the |
|
Dear @mterzo, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @mterzo, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @mterzo, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
3 participants
On MR #27 Hiera lookup started using
cron::job::XXXwhich also turned around and usedcreate_resrouces('cron::job::XXX'.These resources were not in the job directory. I've moved them there. I can only assume that these were lookups were changed due to puppet4's new parameters and having hourly, month, etc were giving warnings as parameters to the cron class.