32 task operation mode msg srv #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jorgenfj
requested changes
Jan 8, 2026
Contributor
jorgenfj
left a comment
jorgenfj
left a comment
There was a problem hiding this comment.
Move the constants to the .msg file. For the service the
srv/OperationModeSRV.srv
Outdated
Comment on lines
5
to
7
| uint8 KILLSWITCH = 0 | ||
| uint8 AUTONOMOUS = 1 | ||
| uint8 MANUAL = 2 |
Contributor
There was a problem hiding this comment.
Move constants to the .msg file
| @@ -0,0 +1,12 @@ | |||
| #request | |||
| uint8 mode | |||
Contributor
There was a problem hiding this comment.
This field should be the operation mode msg to be more explicit
srv/OperationModeSRV.srv
Outdated
| uint8 mode | ||
| bool absolute | ||
|
|
||
| uint8 KILLSWITCH = 0 |
Contributor
There was a problem hiding this comment.
Avoid using 0 as a constant to avoid bugs with uninitialized values
Contributor
|
I think it makes more sense to name the service something like |
eirisak
force-pushed
the
32-task-operation-mode-msg-srv
branch
from
4eff02f to
9549a9d
Compare
Andeshog
reviewed
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Why have both SetKillswitch and ToggleKillswitch? Is it not sufficient with one of them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added operation mode message type
Added operation mode service type