Skip to content

Expose expressions for C API#7190

Merged
myrrc merged 1 commit intodevelopfrom
myrrc/expressions-ffi
Mar 30, 2026
Merged

Expose expressions for C API#7190
myrrc merged 1 commit intodevelopfrom
myrrc/expressions-ffi

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Mar 27, 2026

Expose a subset of expressions to test filtering in Scan API:
root, get_item, select, or, not, is_null, and binary operators.
Add vx_array_apply to test C-side expression application.

This patch does not include C++ FFI tests because we can't create vx_arrays' yet, #7148.
The next steps are exposing literal expressions and dynamic expressions.

Additional change: Fix sanitizer flags for CI to actually run CI with asan and tsan.

@myrrc myrrc added the changelog/feature A new feature label Mar 27, 2026
@myrrc myrrc requested a review from 0ax1 March 27, 2026 15:46
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch from f27c320 to ccff59e Compare March 27, 2026 15:50
@myrrc myrrc marked this pull request as ready for review March 27, 2026 15:50
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch from ccff59e to 1bc107f Compare March 27, 2026 15:59
@myrrc myrrc enabled auto-merge (squash) March 27, 2026 16:05
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch from 1bc107f to bc6ab5f Compare March 27, 2026 16:11
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 27, 2026

Merging this PR will not alter performance

✅ 1106 untouched benchmarks
⏩ 1522 skipped benchmarks1


Comparing myrrc/expressions-ffi (c98aa74) with develop (a545239)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@0ax1
Copy link
Copy Markdown
Contributor

0ax1 commented Mar 30, 2026

worthwhile that @joseph-isaacs has a look who worked a lot with expr in vortex

@myrrc myrrc force-pushed the myrrc/expressions-ffi branch from d000145 to 67b5c3c Compare March 30, 2026 12:55
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch 3 times, most recently from a9b51a5 to 9c4e679 Compare March 30, 2026 13:24
@myrrc myrrc requested a review from joseph-isaacs March 30, 2026 13:24
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch 2 times, most recently from 4678def to 3bbdadc Compare March 30, 2026 13:27
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch from 3bbdadc to 8aabd95 Compare March 30, 2026 13:38
@myrrc myrrc requested a review from joseph-isaacs March 30, 2026 13:38
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch from 8aabd95 to 5e8310c Compare March 30, 2026 13:41
@myrrc myrrc requested a review from 0ax1 March 30, 2026 13:52
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
Signed-off-by: Mikhail Kot <to@myrrc.dev>
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch from 5e8310c to c98aa74 Compare March 30, 2026 14:06
@myrrc myrrc merged commit f3a9ff5 into develop Mar 30, 2026
58 checks passed
@myrrc myrrc deleted the myrrc/expressions-ffi branch March 30, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants