Skip to content

Type Coercion#6960

Merged
gatesn merged 8 commits intodevelopfrom
ngates/type-coercion
Mar 13, 2026
Merged

Type Coercion#6960
gatesn merged 8 commits intodevelopfrom
ngates/type-coercion

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Mar 13, 2026 •
edited
Loading

This allows Vortex expressions to be typed in contexts that currently don't have their own logical planner, for example expressions passed into PyVortex.

gatesn added 2 commits March 13, 2026 14:35
@gatesn
Add type coercion to scalar functions and extension types
9115a8f 
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn
Add type coercion to scalar functions and extension types
f210a04 
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/feature A new feature label Mar 13, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 1009 untouched benchmarks
⏩ 1515 skipped benchmarks1

Comparing ngates/type-coercion (f5d2adf) with develop (da4c196)

Open in CodSpeed

Footnotes

  1. 1515 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@gatesn
Add type coercion to scalar functions and extension types
fee68a4 
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn marked this pull request as ready for review March 13, 2026 18:44
gatesn added 4 commits March 13, 2026 15:00
@gatesn
Add type coercion to scalar functions and extension types
09430b8 
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn
Add type coercion to scalar functions and extension types
f24caa3 
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn
Add type coercion to scalar functions and extension types
3250b1a 
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn
Add type coercion to scalar functions and extension types
c6b6da7 
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn enabled auto-merge (squash) March 13, 2026 19:17
@gatesn gatesn requested a review from lwwmanning March 13, 2026 19:18
@gatesn gatesn disabled auto-merge March 13, 2026 19:23
connortsui20
connortsui20 reviewed Mar 13, 2026
View reviewed changes
vortex-array/src/expr/transform/coerce.rs
Comment on lines +52 to +53
if child_dtype.eq_ignore_nullability(target)
&& child_dtype.nullability() == target.nullability()
Copy link
Contributor

@connortsui20 connortsui20 Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just eq?

connortsui20
connortsui20 reviewed Mar 13, 2026
View reviewed changes
vortex-array/src/dtype/coercion.rs
return Some(self.with_nullability(self.nullability() | other.nullability()));
}

let union_null = self.nullability() | other.nullability();
Copy link
Contributor

@connortsui20 connortsui20 Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: move this up

@gatesn
Add type coercion to scalar functions and extension types
f5d2adf 
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn enabled auto-merge (squash) March 13, 2026 19:38
@gatesn gatesn disabled auto-merge March 13, 2026 19:55
@gatesn gatesn merged commit 74a31af into develop Mar 13, 2026
94 of 96 checks passed
@gatesn gatesn deleted the ngates/type-coercion branch March 13, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connortsui20 connortsui20 connortsui20 approved these changes

@lwwmanning lwwmanning Awaiting requested review from lwwmanning

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gatesn @connortsui20