Merged
Conversation
Logic to convert bit buffers into transpose layout. This is useful where intermediary arrays are in transpose layout Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
commented
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic to convert bit buffers into transpose layout. This is useful where
intermediary arrays are in transpose layout
In particular this is necessary to handle DeltaArray validity correctly
On Zen 5 the bmi instructions are 20-30% faster, VBMI are ~10-20x faster
On Zen3 bmi instructions are still around 20-30% faster
On M4 the neon version is ~60-100% faster while untranspose stays the same
Full benchmark results for posterity
on Zen 5 machine (m8azn)
on a Zen 3 machine (c6a)
on a M4 Max
Signed-off-by: Robert Kruszewski github@robertk.io