Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingSummary
datafusion / vortex-file-compressed (0.975x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
datafusion / vortex-file-compressed (0.997x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.008x ➖, 0↑ 0↓)
datafusion / parquet (1.003x ➖, 0↑ 0↓)
datafusion / arrow (1.020x ➖, 1↑ 2↓)
duckdb / vortex-file-compressed (1.004x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.994x ➖, 0↑ 0↓)
duckdb / parquet (1.014x ➖, 3↑ 4↓)
duckdb / duckdb (1.024x ➖, 0↑ 1↓)
|
Contributor
Benchmarks: FineWeb NVMeSummary
datafusion / vortex-file-compressed (0.912x ➖, 4↑ 0↓)
datafusion / vortex-compact (0.914x ➖, 4↑ 0↓)
datafusion / parquet (0.867x ✅, 6↑ 0↓)
duckdb / vortex-file-compressed (0.874x ✅, 7↑ 0↓)
duckdb / vortex-compact (0.897x ✅, 5↑ 0↓)
duckdb / parquet (0.911x ➖, 5↑ 0↓)
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
datafusion / vortex-file-compressed (1.027x ➖, 0↑ 2↓)
datafusion / vortex-compact (1.020x ➖, 1↑ 1↓)
datafusion / parquet (1.021x ➖, 0↑ 3↓)
duckdb / vortex-file-compressed (1.001x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.008x ➖, 1↑ 3↓)
duckdb / parquet (1.011x ➖, 0↑ 1↓)
duckdb / duckdb (1.008x ➖, 1↑ 5↓)
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
datafusion / vortex-file-compressed (0.671x ✅, 6↑ 3↓)
datafusion / vortex-compact (1.263x ➖, 0↑ 5↓)
datafusion / parquet (1.107x ➖, 0↑ 4↓)
duckdb / vortex-file-compressed (1.001x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.007x ➖, 1↑ 0↓)
duckdb / parquet (0.996x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
duckdb / vortex-file-compressed (0.974x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.974x ➖, 0↑ 0↓)
duckdb / parquet (0.977x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Clickbench on NVMESummary
datafusion / vortex-file-compressed (0.954x ➖, 2↑ 0↓)
datafusion / vortex-compact (0.955x ➖, 3↑ 0↓)
datafusion / parquet (0.957x ➖, 2↑ 0↓)
duckdb / vortex-file-compressed (0.950x ➖, 3↑ 0↓)
duckdb / vortex-compact (0.943x ➖, 6↑ 1↓)
duckdb / parquet (0.972x ➖, 0↑ 0↓)
duckdb / duckdb (0.948x ➖, 4↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
datafusion / vortex-file-compressed (0.939x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.944x ➖, 0↑ 0↓)
datafusion / parquet (0.961x ➖, 0↑ 0↓)
datafusion / arrow (0.935x ➖, 3↑ 1↓)
duckdb / vortex-file-compressed (0.932x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.949x ➖, 0↑ 0↓)
duckdb / parquet (0.975x ➖, 0↑ 0↓)
duckdb / duckdb (0.957x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: FineWeb S3Summary
datafusion / vortex-file-compressed (1.043x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.045x ➖, 0↑ 1↓)
datafusion / parquet (1.000x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.974x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.979x ➖, 0↑ 0↓)
duckdb / parquet (1.032x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Random AccessSummary
unknown / unknown (0.953x ➖, 6↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
datafusion / vortex-file-compressed (0.894x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.786x ➖, 2↑ 0↓)
datafusion / parquet (0.930x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (0.841x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.877x ➖, 0↑ 0↓)
duckdb / parquet (0.957x ➖, 0↑ 0↓)
|
Signed-off-by: Nicholas Gates <nick@nickgates.com>
| */ | ||
| typedef struct Nullability Nullability; | ||
|
|
||
| typedef struct Primitive Primitive; |
Contributor
Author
There was a problem hiding this comment.
I poked around for like 2 hours last night and honestly I have no idea... but didn't feel problematic enough to care about.
Contributor
|
Look like a few other commits got it |
robert3005
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are about to move more functions onto the VTable struct. To make this API nicer for users we're renaming FooVTable to Foo. Since users don't really interact with these structs at the moment, it should have a relatively small blast radius.
That said, anyone who has code like this should update it