-
Notifications
You must be signed in to change notification settings - Fork 141
feat: add clickhouse-bench with auto-downloaded ClickHouse binary #6736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fastio
wants to merge
8
commits into
vortex-data:develop
Choose a base branch
from
fastio:integration-clickhouse-benchmark-baseline
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c1f854f
feat: add clickhouse-bench with auto-downloaded ClickHouse binary
fastio 38d2fe7
bench(clickbench): tighten ClickHouse query normalization and URL han…
fastio 64834ed
bench(clickhouse): remove build-time binary download, resolve clickho…
fastio 1bfefb0
bench(clickhouse): fix review issues and pin LTS version
fastio 7fffcf5
Remove the and helpers that were only needed for ClickHouse unquoted…
fastio 5aa201a
fix build errors
fastio fb28623
Merge branch 'develop' into integration-clickhouse-benchmark-baseline
fastio 14df836
update Cargo.lock
fastio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| [package] | ||
| name = "clickhouse-bench" | ||
| description = "ClickHouse (clickhouse-local) benchmark runner for Vortex" | ||
| authors.workspace = true | ||
| edition.workspace = true | ||
| homepage.workspace = true | ||
| license.workspace = true | ||
| readme.workspace = true | ||
| repository.workspace = true | ||
| rust-version.workspace = true | ||
| version.workspace = true | ||
| publish = false | ||
|
|
||
| [dependencies] | ||
| anyhow = { workspace = true } | ||
| clap = { workspace = true, features = ["derive"] } | ||
| tokio = { workspace = true, features = ["full"] } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I doubt you need "full" features here |
||
| tracing = { workspace = true } | ||
| vortex-bench = { workspace = true } | ||
|
|
||
| [lints] | ||
| workspace = true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // SPDX-FileCopyrightText: Copyright the Vortex contributors | ||
|
|
||
| //! Build script that exports the ClickHouse binary path. | ||
| //! | ||
| //! Resolution order: | ||
| //! 1. `CLICKHOUSE_BINARY` env var — use as-is. | ||
| //! 2. Falls back to `"clickhouse"` (i.e., resolve from `$PATH` at runtime). | ||
| //! | ||
| //! Users must install ClickHouse themselves for local runs. | ||
| //! In CI, it is installed via the workflow before the benchmark step. | ||
|
|
||
| fn main() { | ||
| println!("cargo:rerun-if-env-changed=CLICKHOUSE_BINARY"); | ||
|
|
||
| let binary = std::env::var("CLICKHOUSE_BINARY").unwrap_or_else(|_| "clickhouse".to_string()); | ||
| println!("cargo:rustc-env=CLICKHOUSE_BINARY={binary}"); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look above at the lance setup code, we have a better guard against benching something on remote that is not supposed to be, can you mimic that?