Skip to content

Conversation

@phts
Copy link
Contributor

@phts phts commented Jan 9, 2024

Screenshot 2024-01-09 at 15 02 17

Taken from spotify/web-api#687

Do you want to sort it somehow?

@volumio
Copy link
Owner

volumio commented Jan 9, 2024

Thanks @phts for this. However I am for integrating only choices which make sense (for example tablet or chromecast does not make sense because it will never be used). Would you mind adding only icons which could make sense for our usage scenario?

@phts
Copy link
Contributor Author

phts commented Jan 9, 2024

hi @volumio

Yes, agree to remove cast devices, because spotify app adds unnessesary label "Chomecast" for such type, which is not relevant

But for other icons - Those are just icons. And users can choose any icon which better match to their device (formfactor, use cases, etc). If user created device similar to tablet, then let's allow him to choose icon "tablet" which looks like his device.

Anyways up to you. You can choose what icons you want to keep:

(I would remove only duplicated, however maybe android app has such duplicated icons... )

{
  "value": "avr",
  "label": "AV Receiver"
},
{
  "value": "speaker",
  "label": "Speaker"
},
{
  "value": "stb",
  "label": "Set-Top Box"
},
{
  "value": "computer",
  "label": "Computer"
},
{
  "value": "tablet",
  "label": "Tablet"
},
{
  "value": "smartphone",
  "label": "Smartphone"
},
{
  "value": "tv",
  "label": "TV"
},
{
  "value": "audio_dongle",
  "label": "Audio dongle"
},
{
  "value": "game_console",
  "label": "Game console"
},
{
  "value": "automobile",
  "label": "Car device"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants