feat(metrics): fan out vikingdb collection metrics across accounts#1830
Open
arminzou wants to merge 3 commits intovolcengine:mainfrom
Open
feat(metrics): fan out vikingdb collection metrics across accounts#1830arminzou wants to merge 3 commits intovolcengine:mainfrom
arminzou wants to merge 3 commits intovolcengine:mainfrom
Conversation
- allow vikingdb collection metrics to carry account_id labels - fan out vikingdb state reads across default and api-key-managed accounts - mark partial per-account failures stale instead of fresh zeroes - reuse last known vectors for failed accounts in collector fallback - cover multi-account and partial-failure behavior in tests
PR Reviewer Guide 🔍(Review updated until commit d023efc)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
arminzou
force-pushed
the
feat/vikingdb-account-metrics-fanout
branch
from
5c41e2a to
72b7c50
Compare
arminzou
force-pushed
the
feat/vikingdb-account-metrics-fanout
branch
from
72b7c50 to
d023efc
Compare
|
Persistent review updated to latest commit d023efc |
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
account_idon the VikingDB collection metric families and preserve stale semantics on per-account partial failuresaccount_idselector to source from VikingDB metrics directlyMotivation
This replaces the earlier default-account-only approach behind #1760 with actual per-account fan-out so the
account_idlabel is semantically accurate.Changes
openviking_vikingdb_collection_healthandopenviking_vikingdb_collection_vectorsto the account-dimension allowlistvalid="0") instead of exporting fresh zero-count samplesaccount_idvariable fromopenviking_vikingdb_collection_vectorsTest Plan
tests/metrics/collectors/test_state_collectors.py tests/metrics/datasources/test_state_datasources.py)examples/grafana/openviking_demo_dashboard.jsonScreenshots / Examples
N/A
Notes for Reviewers
mainand is not stacked on the closed fix(metrics): scope vikingdb vector count to configured default account #1760.valid="0") from the last successful scrape, not zero. On the next successful scrape the stale series is replaced with fresh data and placeholder fallback entries are removed./cc @qin-ctx