fix(storage): let replace mode create missing files#1788
fix(storage): let replace mode create missing files#1788Gujiassh wants to merge 1 commit intovolcengine:mainfrom
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
7e3b5e0 to
f4e4f9c
Compare
|
Thanks for the PR. I do not think we should change This PR changes that API contract silently: a request with My preference is to keep
So I would not merge this PR in its current form. The safer direction is either to close this as expected |
Summary
This fixes issue #1709 by making
mode=replacefall back to the existing create path when the target file does not exist yet.The change is intentionally small:
write()to stat withallow_not_foundformode=replace_create_and_write(...)instead of surfacingNotFoundErrorVerification
Local checks completed:
python3 -m py_compile openviking/storage/content_write.py tests/server/test_content_write_service.pyFocused pytest could not complete in this checkout because the repo test harness import is currently blocked by missing local Python deps (
pytest_asyncio/pydantic) before the selected test module can run.Related