VOIP-1290-Fix-trunk-domain-string-typos - #1178
Merged
Merged
Conversation
Fix a cosmetic naming mismatch flagged during the VOIP-1290 RST docs audit: several log/error strings in the trunk service handler said "domain" when they actually refer to trunks. - bin-api-manager: Rename "domain" to "trunk" in 5 log/error strings in pkg/servicehandler/trunk.go (TrunkDelete's debug/error messages, TrunkGet's "domain_id" log field key -> "trunk_id" to match the other three handler functions in the file, and TrunkUpdateBasicInfo's wrapped error message). No behavior change; the legitimate domainName/domain_name SIP-domain field on TrunkCreate is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a cosmetic naming mismatch flagged during the VOIP-1290 RST docs audit (item 14): several log/error strings in the trunk service handler said "domain" when they actually refer to trunks.