-
Notifications
You must be signed in to change notification settings - Fork 21
Enhancement on the SubnetPort realization performance #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/e2e |
e9018fc
to
def89e6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
- Coverage 74.50% 74.48% -0.03%
==========================================
Files 147 147
Lines 23501 23527 +26
==========================================
+ Hits 17509 17523 +14
- Misses 4910 4920 +10
- Partials 1082 1084 +2
🚀 New features to boost your workflow:
|
def89e6
to
f332d28
Compare
f332d28
to
9096bc8
Compare
9096bc8
to
126df80
Compare
Can you confirm Subnet response API can return gateway address and network address in 9.0 as well? |
126df80
to
e15e50a
Compare
e15e50a
to
3774f7c
Compare
e183faf
to
ac050ac
Compare
/e2e |
1 similar comment
/e2e |
ac050ac
to
1305f48
Compare
1305f48
to
c445047
Compare
25aef6c
to
ade8787
Compare
1. Avoid the uncessary SubnetPort state check if the stauts indicates that the port has been realized successfully. 2. Get the Subnet's gateway address from Subnet store instead of Subnet status API to reduce the frequency of NSX API calls. Testing done: 1. Created 3000 ports in the single Subnet (ipv4SubnetSize=4096), it took 34 minutes to complete the realization(previously the time is > 90 minutes). 2. Created 3000 ports in the defualt SubnetSet (ipv4SubnetSize=32), it took 36 minutes to complete the realization.
ade8787
to
dfd3a8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overalll LGTM. Just a thought for future changes.
Enhancement on the SubnetPort realization performance
the port has been realized successfully.
status API to reduce the frequency of NSX API calls.
Testing done:
34 minutes to complete the realization(previously the time is > 90 minutes).
36 minutes to complete the realization.