Give code spans precedence over link brackets - #817
Open
flavorjones wants to merge 1 commit into
Open
Conversation
Per the CommonMark spec, code spans, autolinks, and raw HTML bind more
tightly than the brackets in link text. `char_link` in
`ext/redcarpet/markdown.c` scanned for the closing `]` of a link label
without any awareness of code spans, so a `]` inside a code span closed
the label. Given `[`text](/one)`](/two)`, Redcarpet previously produced
<p><a href="/one">`text</a>`](/two)</p>
Now it produces the link a compliant parser emits, matching `cmark`:
<p><a href="/two"><code>text](/one)</code></a></p>
The same label scan decided whether a character was escaped by testing a
single preceding byte, which misread a backtick following an escaped
backslash (`\\`). HTML-to-Markdown generators such as `turndown` emit
exactly that sequence, so the naive check defeated the precedence fix on
their output. The check now counts the run of preceding backslashes and
treats a character as escaped only when that run has odd length.
Footnote identifiers are not inline content, so the precedence rule does
not apply to them. The scan skips code spans only for ordinary link and
image labels, leaving footnote references parsed as before.
Fixes vmg#816.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the CommonMark spec, code spans, autolinks, and raw HTML bind more tightly than the brackets in link text.
char_linkinext/redcarpet/markdown.cscanned for the closing]of a link label without any awareness of code spans, so a]inside a code span closed the label. Given the input:Redcarpet previously produced:
Now it produces the link a compliant parser emits, matching
cmark:The same label scan decided whether a character was escaped by testing a single preceding byte, which misread a backtick following an escaped backslash (
\\). HTML-to-Markdown generators such asturndownemit exactly that sequence, so the naive check defeated the precedence fix on their output. The check now counts the run of preceding backslashes and treats a character as escaped only when that run has odd length.Footnote identifiers are not inline content, so the precedence rule does not apply to them. The scan skips code spans only for ordinary link and image labels, leaving footnote references parsed as before.
Fixes #816.