Autolink: fix invalid string when email is followed by a multibyte character#812
Open
goulvench wants to merge 2 commits into
Open
Autolink: fix invalid string when email is followed by a multibyte character#812goulvench wants to merge 2 commits into
goulvench wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sd_autolink__emailwas using rawisalnumto detect email addresses, butisalnumcan return true for non-ASCII bytes. This caused autolink to incorrectly capture trailing multibyte characters (e.g. contact@example.com中 would include the lead byte of 中 at the end of the email).markdown.calready had a_isalnumhelper that combinesisalnumwith an explicitc < 0x7fguard for exactly this reason. This PR moves that helper toautolink.h(which is included by both files viamarkdown.h) and uses it consistently insd_autolink__email.Fixes #811