Stop newlines from generating invalid html#709
Open
seangoedecke wants to merge 1 commit into
Open
Conversation
Previously, adding `\n` in the middle of html tags would cause the markdown generator to wrap some html fragment in `<p>` tags, often causing the generation of invalid html like this: `<div><p></div></p>` This commit adds a check in the paragraph generation code to treat the content as plain html if it begins with a closing html tag.
Author
|
This change also fixes #652, FWIW. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my crack at fixing #703
Previously, adding
\nin the middle of html tags would cause the markdown generator to wrap some html fragment in<p>tags, often causing the generation of invalid html like this:<div><p></div></p>This commit adds a check in the paragraph generation code to treat the content as plain html if it begins with a closing html tag.
I'm not thrilled about how I'm detecting closing html tags and differentiating them from angle-bracket relative links like
[a](</link>)- if there's machinery elsewhere in the codebase for doing that that I missed, I'm very happy to refactor to use that.