Replace ACE with native IO implementation #2740
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow applications like Putty to connect to the server
Native Branch: Remote Access Terminal without ACE
Bug introduced in a566778
Native Branch: MaNGOS gSOAP without ace
Update native branch
Update native branch
Update native branch
…rs at server shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This pr will replace ACE with a self-made but highly performant native solution.
The implementation was inspired by boost asio, meaning that everything is asynchronous and requires a callback.
Users have to guarantee the lifetime of the socket throughout the transaction (aka. use
std::shared_ptr<>).Since cMaNGOS and TrinityCore already switched to Boost and this native IO implementation is very similar to Boost, some similarities in the network code can be found and compared against.
Native system function are used. There are slightly different backend implementations on each OS:
IOCPepoll(with the possibility to addio_uringsupport)kqueueWant to test it? 🧪
Just merge these two commits into your repo.
https://github.com/0blu/vmangos-core/tree/native-squash-merge-2024-11-17
As soon this
nativebranched is squashed-merged withdevelopmentyou can easily rebase->drop->cherry-pick it with the new official commit.Todo / Checklist