Skip to content

Conversation

@xuechendi
Copy link
Contributor

@xuechendi xuechendi commented Nov 17, 2025

Purpose

quick fix when block_size=128, need to update physical_block_size to self.kv_topo

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a critical bug in the NIXL connector related to heterogeneous block sizes. When the logical block size from the configuration differs from the physical block size required by the attention kernel, the worker's block_size attribute is updated. However, the original code failed to propagate this update to the kv_topo.block_size and _block_size attributes, which would lead to inconsistent state and incorrect calculations for KV cache transfers. The change correctly synchronizes these attributes, ensuring the integrity of the heterogeneous block size logic. The fix is well-targeted and necessary for the correct functioning of the NIXL connector in such scenarios.

@xuechendi
Copy link
Contributor Author

@NickLucche , need help for quick review for fixing block_size=128 after supporting heter block size.
Will need to set physical block size in self.kv_topo

@mergify mergify bot added the v1 label Nov 18, 2025
@xuechendi xuechendi force-pushed the dev/fix_blocksize128 branch from a9b14cb to 3c736a7 Compare November 18, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant