[Refactor] Remove Unused Func in Batch Invariant #28881
Merged
+0
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yewentao256 <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the batch invariant feature by removing several unused functions, including disable_batch_invariant_mode and the set_batch_invariant_mode context manager. The goal is to simplify maintenance by removing the ability to toggle this feature at runtime. While this simplifies the code, I have a significant concern about removing the cleanup logic, as it makes process-wide changes to PyTorch and environment variables permanent, which can negatively impact applications using vLLM as a library.
Signed-off-by: yewentao256 <[email protected]>
tlrmchlsmth
approved these changes
Nov 17, 2025
Member
|
Entrypoint tests are failing on main, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We don't hope user to turn on/off batch invariant during inferrence, so just remove the code for better maintainence