Skip to content

Conversation

@ashors1
Copy link
Contributor

@ashors1 ashors1 commented Nov 15, 2025

Purpose

The signature for _load_weights_other is incorrect. The start and end indices are flipped, which casues an indexing issue when attempting to extract the weights on the current EP rank. This fixes the signature to be consistent with _load_weights_mxfp4.

Test Plan

Test Result

Running _load_weights_other with EP now works as expected.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies and fixes a bug in the _load_weights_other method within the GptOssModel class. The parameters ep_rank_start and ep_rank_end were swapped in the function signature, leading to incorrect weight slicing when using expert parallelism. The change aligns the signature with its call site and makes it consistent with the _load_weights_mxfp4 method, resolving the indexing issue. The fix is accurate and well-contained.

Copy link
Collaborator

@jikunshang jikunshang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! thanks for fixing.

@github-project-automation github-project-automation bot moved this from To Triage to Ready in gpt-oss Issues & Enhancements Nov 15, 2025
@jikunshang jikunshang enabled auto-merge (squash) November 15, 2025 01:22
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 15, 2025
@jikunshang jikunshang merged commit 8d259fa into vllm-project:main Nov 16, 2025
51 checks passed
bwasti pushed a commit to bwasti/vllm that referenced this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gpt-oss Related to GPT-OSS models ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants