Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Nov 14, 2025

Purpose

SchedulerConfig.chunked_prefill_enabled is redundant with SchedulerConfig.enable_chunked_prefill, so I've renamed all occurrences of the former to the latter. For plugin compatibility, I've deprecated the old property instead of removing it immediately.

Follow-up to #28665 (comment)

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a nice cleanup that removes the redundant SchedulerConfig.chunked_prefill_enabled property and replaces all its usages with SchedulerConfig.enable_chunked_prefill. The changes are consistent across the codebase, including configurations, scheduler logic, and tests. The refactoring is well-executed and improves code clarity. I have reviewed all the changes and found no issues. The PR is good to merge.

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@njhill
Copy link
Member

njhill commented Nov 14, 2025

AFAIK this parameter now only affects the multimodal case when determining max mm items per batch. I wonder whether we should log some warning if it's set to a non-default value since folks might think they can disable prefill chunking when they in fact can't.

But actually is that also what SchedulerConfig.disable_chunked_mm_input does? In which case should we remove chunked_prefill_enabled altogether?

@DarkLight1337
Copy link
Member Author

Hmm, we can control chunked prefill for pooling models though?

@DarkLight1337
Copy link
Member Author

Scheduler code seems to take care of chunked prefill enable/disable, but it's possible that model runner makes some assumptions about that for MM or generative models, not 100% sure about this.

cc @ywang96 @maxdebayser @noooop

@njhill
Copy link
Member

njhill commented Nov 14, 2025

Hmm, we can control chunked prefill for pooling models though?

@DarkLight1337 ah sorry yes I missed that. Still I wonder if we should warn in non-pooling case.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 14, 2025 17:54
@DarkLight1337
Copy link
Member Author

Still I wonder if we should warn in non-pooling case.

In any case let's merge this first. We can update the message in another PR.

@DarkLight1337 DarkLight1337 merged commit e2741f6 into vllm-project:main Nov 14, 2025
47 checks passed
@DarkLight1337 DarkLight1337 deleted the rename-chunked-prefill branch November 14, 2025 18:39
geodavic pushed a commit to geodavic/vllm that referenced this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants