-
Notifications
You must be signed in to change notification settings - Fork 294
Add Olmo3 AWQ mapping #2063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Olmo3 AWQ mapping #2063
Conversation
Signed-off-by: lkm2835 <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @lkm2835, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for quantizing Olmo3 language models using Activation-aware Weight Quantization (AWQ). By leveraging an existing mapping configuration that aligns with Olmo3's architectural design, this change allows for improved inference efficiency for Olmo3 models. The integration has been validated through testing, demonstrating successful text generation post-quantization. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an AWQ (Activation-aware Weight Quantization) mapping for the Olmo3 model architecture. The change correctly identifies that Olmo3 shares a similar decoder structure with EXAONE4, particularly its pre-normalization scheme, and thus reuses the _exaone4_mappings. The new mapping is added to AWQ_MAPPING_REGISTRY in the correct alphabetical position, maintaining code organization. The provided test results confirm that this change is necessary and effective for generating coherent output with the quantized Olmo3 model. The change is straightforward, well-justified, and I have no comments.
kylesayrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Huggingface: Olmo 3 Collection
Transformers: Olmo3DecoderLayer
Olmo3 uses the same decoder layer structure as EXAONE4. Related to #2046.
Test
Tested it with
examples/awq/llama_example.pyand modifiedMODEL_ID="allenai/Olmo-3-1125-32B".with
_exaone4_mappingswith
_default_mappings