Skip to content

[TypeHint] Fix format_calibration_data type hint #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

[TypeHint] Fix format_calibration_data type hint #2012

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89dc709
fix
kylesayrs Nov 10, 2025
3b21f87
Merge branch 'main' into kylesayrs/typehintfix
dsikka Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/llmcompressor/datasets/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def format_calibration_data(
num_calibration_samples: int | None = None,
do_shuffle: bool = True,
collate_fn: Callable = default_data_collator,
) -> list[torch.Tensor]:
) -> DataLoader:
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With this change, the function's docstring is now inconsistent with the return type hint. The :return: description on line 141 still describes the old return type (list of trimmed calibration data tensors). Please update the docstring to reflect that a DataLoader is returned to maintain consistency.

"""
Creates a dataloader out of the calibration dataset split, trimming it to
the desired number of calibration samples
Expand Down
Loading