Add Hotkeys Plugin

[rtritto]

Close #161

Related Video.js plugin: https://github.com/ctd1500/videojs-hotkeys

This PR contains a:

• bugfix
• new feature
• code refactor
• test update
• typo fix
• metadata update

[vercel]

@rtritto is attempting to deploy a commit to the Vlitejs Team on Vercel.

A member of the Team first needs to authorize it.

[yoriiis]

The following lines needs to be removed

• vlite/src/core/vlite.ts

  Line 210 in 8a45ec7

  this.container.addEventListener('keydown', this.onKeydown)

• vlite/src/core/vlite.ts

  Line 375 in 8a45ec7

  this.container.removeEventListener('keydown', this.onKeydown)

[yoriiis]

Thanks @rtritto for the contribution!

Feel free to improve the plugin sample or contributing guide if you have idea from your contribution

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
vlite	✅ Ready (Inspect)	Visit Preview	Mar 3, 2025 11:10am

[rtritto]

The following lines needs to be removed

* https://github.com/vlitejs/vlite/blob/8a45ec788be3d4843ffbe23c75fd13af9424e585/src/core/vlite.ts#L210

* https://github.com/vlitejs/vlite/blob/8a45ec788be3d4843ffbe23c75fd13af9424e585/src/core/vlite.ts#L375

Should the 2 lines be adapted in hotkeys.ts or we can simple remove them?

[yoriiis]

@rtritto Please, don't force pushed, keep all commits it is more easy for the review. I will squashed them on merge or require a squash only at the end

[yoriiis]

The following lines needs to be removed

* https://github.com/vlitejs/vlite/blob/8a45ec788be3d4843ffbe23c75fd13af9424e585/src/core/vlite.ts#L210

* https://github.com/vlitejs/vlite/blob/8a45ec788be3d4843ffbe23c75fd13af9424e585/src/core/vlite.ts#L375

Should the 2 lines be adapted in hotkeys.ts or we can simple remove them?

The lines should be removed from vlite.ts and added in the plugin. You will need to adapt the this.container as you have already done

[rtritto]

@rtritto Please, don't force pushed, keep all commits it is more easy for the review. I will squashed them on merge or require a squash only at the end

I will squash every time because it's clear, easy to read history and the merge uses at least 2 commits

[yoriiis]

Could you add the plugin on the demo? Will be more easy to check it on the preview. Thanks

https://github.com/vlitejs/vlite/blob/main/examples/html5/config.js

[rtritto]

Could you add the plugin on the demo? Will be more easy to check it on the preview. Thanks

https://github.com/vlitejs/vlite/blob/main/examples/html5/config.js

Done in the commit 4ab32a3

[yoriiis]

Question about the version for this updates. Shortcut will be removed from the default behavior but I don't want to publish a major release just for this "minor" imo changes. A minor bump probably, good for you also?

[rtritto]

Shortcut will be removed from the default behavior but I don't want to publish a major release just for this "minor" imo changes.

Yes, it's a breaking change.

A minor bump probably, good for you also?

Yes, it's the only alternative if you don't wont to bump the major version.