cgen: fix interface pass string ref arg #26296
Open
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| fn test_interface_string_ref_arg() { | ||
| params := generate_params('[email protected]') |
Contributor
There was a problem hiding this comment.
I don't think using an email address (to a domain we do not control) is a good idea
Maybe switch the string to 'kbkpbot'
Delta456
approved these changes
Jan 9, 2026
spytheman
reviewed
Jan 9, 2026
Member
There was a problem hiding this comment.
Please add an assertion too. Without one, it only checks that the test compiles, but it is not clear what does it do, and what feature is tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26293
When converting a value-type function argument (e.g.,
string) to an interface type (e.g.,Value), the compiler incorrectly used direct address-of (&) operation instead of heap allocation. This caused a dangling pointer issue because the function argument is a local variable that gets destroyed when the function returns, but the interface still held a pointer to the invalidated memory, leading to runtime memory access errors.