Skip to content

Prefetch stereo cubemaps #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timoxley wants to merge 2 commits into
base: vizor
Choose a base branch
from
Open

Prefetch stereo cubemaps #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b6991b
Support 12 image stereo cubemap format in prefetch
timoxley Nov 3, 2017
cc5430b
Support stereo cubemaps in Prefetch uriKey.
timoxley Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ReactVR/js/Views/Prefetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default class RCTPrefetch extends RCTBaseView {

if (Array.isArray(uri)) {
// Cubemap, check proper format
if (uri.length !== 6 || !uri[0].uri) {
if ((uri.length !== 6 && uri.length !== 12) || !uri[0].uri) {
console.warn(
'Prefetch expected cubemap source in format [{uri: http..}, {uri: http..}, ... ]'
);
Expand Down Expand Up @@ -82,7 +82,7 @@ export default class RCTPrefetch extends RCTBaseView {
static uriKey(uri) {
if (Array.isArray(uri)) {
// Cubemap, check proper format
if (uri.length === 6) {
if (uri.length === 6 || uri.length === 12) {
const urls = uri.map(RCTPrefetch.getUri);
return urls.join(',');
} else {
Expand Down