volume-pipewire: add flat-list sink+port cycling on click#549
Open
brkay54 wants to merge 1 commit intovivien:masterfrom
Open
volume-pipewire: add flat-list sink+port cycling on click#549brkay54 wants to merge 1 commit intovivien:masterfrom
brkay54 wants to merge 1 commit intovivien:masterfrom
Conversation
Replace sink-only cycling with a flat-list approach that enumerates all (sink, port) pairs. Left/right click now cycles through every output (e.g. BT → Speaker → Headphones) instead of skipping ports on the same sink. Also appends the active port label to the display name when a sink has multiple ports.
Author
|
@vivien need just a quick look, i have tested on my device it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(sink, port)pairs across every available sinkALC257 Analog/Headphones)Problem
When a system has a single sink with multiple ports (e.g. built-in audio with Speaker and Headphones), the previous
set_default_playback_device_nextfunction found only one sink and did nothing on click.Solution
Added two functions:
get_all_outputs— enumerates allsink|portpairs viapactl list sinksset_next_audio_output— finds the current(sink, port)in the flat list, advances by ±1, then callspactl set-default-sinkand/orpactl set-sink-portas neededTest plan