update transient slice expected results after bug fix#12
Closed
weefuzzy wants to merge 3 commits intovitreo12:developfrom
Closed
update transient slice expected results after bug fix#12weefuzzy wants to merge 3 commits intovitreo12:developfrom
weefuzzy wants to merge 3 commits intovitreo12:developfrom
Conversation
Collaborator
Author
|
And then we fixed another bug, and the results changed again... |
Collaborator
|
I will tweak by ear once all the bugs are found. It was a bugger so I'll revert to meat UT comparison of results between versions once you give me the go (and I can compile) |
Collaborator
|
@weefuzzy I presume Alex and you are still working on this - flucoma/flucoma-core#117 is still being updated. Let me know if you need intermediate tests. |
Collaborator
|
I have updated and I am now chasing ghosts of cross-OSes discrepancies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix to the AR model used by transient slice (flucoma/flucoma-core#109) makes it less frisky. This adjusts the expected values in the light of that:
I don't know how attached you were to the existing output. Maybe you'd prefer to tweak settings instead?