Skip to content

Removing redundant flags across binaries#11522

Merged
deepthi merged 10 commits intovitessio:release-15.0from
planetscale:pflag-fixes2
Oct 20, 2022
Merged

Removing redundant flags across binaries#11522
deepthi merged 10 commits intovitessio:release-15.0from
planetscale:pflag-fixes2

Conversation

@rsajwani
Copy link
Copy Markdown
Contributor

@rsajwani rsajwani commented Oct 18, 2022 •
edited
Loading

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

Description

During the audit of pflags across the binaries, we have found some redundancies. This PR

  • Remove redundant flags across binaries
  • Add MarkDeprecated to flags which are going to be deleted in future release

Related Issue(s)

rohit-nayak-ps/vreplication-docs#2

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@rsajwani
removing redundant flags across binaries
a76b54c 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 18, 2022 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rsajwani rsajwani changed the title removing redundant flags across binaries Removing redundant flags across binaries Oct 18, 2022
rsajwani
rsajwani commented Oct 18, 2022
View reviewed changes
@rsajwani
adding app pool flag back for some binaries
db093bf 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani self-assigned this Oct 18, 2022
@rsajwani rsajwani added Forwardport to: main This will forward port the PR to the main branch Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Oct 18, 2022
@rsajwani
running generate_ci on prscomplex.yml
b7163e0 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani marked this pull request as ready for review October 18, 2022 07:35
deepthi
deepthi reviewed Oct 18, 2022
View reviewed changes
deepthi
deepthi reviewed Oct 18, 2022
View reviewed changes
@rsajwani
Merge remote-tracking branch 'upstream/release-15.0' into pflag-fixes2
994e0eb 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani
code review
8eb8eb8 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@deepthi deepthi mentioned this pull request Oct 18, 2022
Closed
3 tasks
@rsajwani
Merge remote-tracking branch 'upstream/release-15.0' into pflag-fixes2
b5c7d74 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani
fixing markdeprecated error
d1c90f7 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani mentioned this pull request Oct 19, 2022
Closed
100 tasks
@rsajwani
code feedback
53d8817 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
deepthi
deepthi reviewed Oct 19, 2022
View reviewed changes
deepthi
deepthi approved these changes Oct 19, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few more small things to fix. Can be merged once those are taken care of.

@rsajwani
doing some minor changes
4c34068 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
deepthi
deepthi reviewed Oct 20, 2022
View reviewed changes
@rsajwani
fixing typo
c6d7b31 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Oct 20, 2022

Thank you for taking care of this!

@deepthi deepthi merged commit 19527a6 into vitessio:release-15.0 Oct 20, 2022
@deepthi deepthi deleted the pflag-fixes2 branch October 20, 2022 17:58
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 20, 2022

I was unable to forwardport this Pull Request to the following branches: main.

@deepthi deepthi mentioned this pull request Oct 21, 2022
Merged
rsajwani added a commit to planetscale/vitess that referenced this pull request Oct 27, 2022
@rsajwani
Removing redundant flags across binaries (vitessio#11522)
5e4c685 
* removing redundant flags across binaries

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* adding app pool flag back for some binaries

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* running generate_ci on prscomplex.yml

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* code review

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fixing markdeprecated error

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* code feedback

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* doing some minor changes

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fixing typo

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani mentioned this pull request Oct 27, 2022
Merged
3 tasks
deepthi pushed a commit that referenced this pull request Nov 1, 2022
@rsajwani
Removing redundant flags across binaries (#11522) (#11589)
adeccd2 
* removing redundant flags across binaries

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* adding app pool flag back for some binaries

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* running generate_ci on prscomplex.yml

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* code review

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fixing markdeprecated error

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* code feedback

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* doing some minor changes

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* fixing typo

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188

@notfelineit notfelineit Awaiting requested review from notfelineit

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@rafael rafael Awaiting requested review from rafael rafael is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

+1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rsajwani rsajwani

Labels

Component: General Changes throughout the code base Forwardport to: main This will forward port the PR to the main branch Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rsajwani @deepthi @systay @frouioui