Add parameterize vreplgen fully, add some docs.#9
Open
aquarapid wants to merge 3 commits intovitessio:mainfrom
Open
Add parameterize vreplgen fully, add some docs.#9aquarapid wants to merge 3 commits intovitessio:mainfrom
aquarapid wants to merge 3 commits intovitessio:mainfrom
Conversation
Supports multiple rules for a stream, as mentioned in the README Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
sougou
reviewed
Oct 28, 2019
| vtctl := "./lvtctl.sh" | ||
| tabletID := "test-400" | ||
| dbName := "vt_merchant" | ||
| argOffset := 0 |
Contributor
There was a problem hiding this comment.
You shouldn't have to use argOffset. It may be because you're calling flag.Parse in init. Can you move it into main and see if it works correctly?
| Rules: rules, | ||
| } | ||
|
|
||
| var onDdlAction binlogdatapb.OnDDLAction |
Contributor
There was a problem hiding this comment.
You can change this to: onDDLAction := binlogdatapb.OnDDLAction_value[strings.ToUpper(onDDL)].
Note that go standards require DDL to be capitalized inside variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports multiple rules for a stream, as mentioned in the README