Open
Conversation
Admin-triggered `/api/executions/add` requests were enqueueing jobs with an empty Vitess version while benchmark configuration is version-gated. For OLAP workloads, `exec-vitess-config` entries such as `mysql_default_workload=OLAP` under version 14+ could be skipped, so admin runs took OLTP execution paths instead of OLAP streaming behavior. The handler also had two missing early returns in error branches, so execution could continue after invalid PR metadata or missing SHA/PR input. This change infers Vitess version before queueing by resolving a reference SHA (PR base for PR requests, requested SHA otherwise), refreshing the local Vitess clone, calling `git.GetVersionForCommitSHA`, and passing the resolved version into `createSimpleExecutionQueueElement`. It also validates unknown workloads up front and restores explicit early returns, so admin and cron paths now apply version-gated flags consistently and follow clearer control flow.
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
mhamza15
requested review from
arthurschreiber,
mattlord,
nickvanw and
timvaillancourt
timvaillancourt
approved these changes
Mar 11, 2026
timvaillancourt
left a comment
timvaillancourt
left a comment
There was a problem hiding this comment.
@mhamza15 some CI is failing, but LGTM overall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Admin-triggered
/api/executions/addrequests were enqueueing jobs with an empty Vitess version while benchmark configuration is version-gated. For OLAP workloads,exec-vitess-configentries such asmysql_default_workload=OLAPunder version 14+ could be skipped, so admin runs took OLTP execution paths instead of OLAP streaming behavior. The handler also had two missing early returns in error branches, so execution could continue after invalid PR metadata or missing SHA/PR input.This change infers Vitess version before queueing by resolving a reference SHA (PR base for PR requests, requested SHA otherwise), refreshing the local Vitess clone, calling
git.GetVersionForCommitSHA, and passing the resolved version intocreateSimpleExecutionQueueElement.Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?