Skip to content

fix(optimizer): serve optimized deps on hash mismatch instead of 504 (fix #22303) #23322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
santhiprakash wants to merge 1 commit into from
+8 −17
Closed

fix(optimizer): serve optimized deps on hash mismatch instead of 504 (fix #22303) #23322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions packages/vite/src/node/plugins/optimizedDeps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,6 @@ export function optimizedDepsPlugin(): Plugin {
// Search in both the currently optimized and newly discovered deps
const info = optimizedDepInfoFromFile(metadata, file)
if (info) {
if (
browserHash &&
info.browserHash !== browserHash &&
!environment.config.optimizeDeps.ignoreOutdatedRequests
) {
throwOutdatedRequest(id)
}
try {
// This is an entry point, it may still not be bundled
await info.processing
Expand All @@ -69,17 +62,15 @@ export function optimizedDepsPlugin(): Plugin {
// returns an empty response that will error.
throwProcessingError(id)
}
const newMetadata = depsOptimizer.metadata
if (metadata !== newMetadata) {
const currentInfo = optimizedDepInfoFromFile(newMetadata!, file)
if (
info.browserHash !== currentInfo?.browserHash &&
!environment.config.optimizeDeps.ignoreOutdatedRequests
) {
throwOutdatedRequest(id)
}
}
}
// We do not throw on `?v=` mismatch here. The browser may have started
// a dynamic import for an optimized dep using the browserHash that was
// baked into the wrapper when it was transformed, before the optimizer
// had a chance to commit a new batch with a different hash. Throwing
// 504 in that case breaks the in-flight import with
// `Failed to fetch dynamically imported module`. Instead, serve the
// current chunk: the optimizer triggers a full reload when its output
// actually changes, which re-issues the request with the new hash.
debug?.(`load ${colors.cyan(file)}`)
// Load the file from the cache instead of waiting for other plugin
// load hooks to avoid race conditions, once processing is resolved,
Expand Down