chore: include changelog notes in GitHub releases - #22916
Closed
AlvaroBalbin wants to merge 1 commit into
Closed
Conversation
Author
|
Following up here. If it would help, I can rebase this onto the current main or adjust anything you'd want changed. No rush, just flagging it is ready when you have a moment. |
Author
|
Hi, just following up on this one. Happy to rebase it on the latest main or make any change that would help it land. Thanks for taking a look whenever you get the chance. |
Member
|
Done in #23116 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22489.
Vite's GitHub Releases only contained a link to CHANGELOG.md, so tools like Dependabot and people reading GitHub notifications couldn't see the actual notes. I updated the release-tag workflow to pull the topmost version section out of the package's CHANGELOG.md and pass it as the release body, so each release now shows its notes inline while the changelog is still maintained as before.
I could not fully run the suite in my environment, so I kept the change small and focused on the issue; a CI run would confirm it.