feat(rsc): expose module runner CJS transform#1265
Open
TheAlexLichter wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR exports the RSC module runner’s CommonJS-to-ESM transform and documents how frameworks can apply it to application
.cjsfiles.Why
The built-in RSC CJS plugin only transforms eligible dependencies from
node_modules. Frameworks may also need to run CJS application modules through Vite’s server module runner.Without this export, frameworks must duplicate the RSC-specific CJS conversion logic or depend on an internal module.
Exposing the transform provides a supported low-level API while leaving file selection and dynamic
require()policy to the integrating framework.Note: This is only relevant if the framework wants to support user-authored or generated .cjs server entries. To my knowledge, this could be beneficial for vinext, marko-js and earthquake.