fix(core): render single overflow dock entry inline instead of behind overflow button - #486
Merged
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dock bar shows a
DockOverflowButton(a badge + popover) once entries exceedmaxVisibleItems. Hiding a single overflowing entry behind a whole button+popover is unnecessary overhead, so it now renders inline instead.This is implemented at the split-algorithm level rather than in the component template:
docksSplitGroupsWithCapacitygains an opt-infoldSingleOverflowoption — when exactly one entry would overflow, it's folded back intovisible(in the slot the overflow affordance would have occupied) instead of being handed to the caller as overflow.Dock.vueopts into it for the bar;DockGroupSidebar.vue's own "show more" rail button is untouched (default behavior unchanged) since it has different overflow-affordance semantics.DockOverflowButtonstill renders as before once two or more entries overflow.Added unit tests for the new option in
dock-sidebar-capacity.test.tsand aSingleOverflowItemStorybook story (Dock.stories.ts) demonstrating the inline behavior.Linked Issues
Additional context
None.
This PR was created with the help of an agent.