Skip to content

fix(core): prevent popup dock icons from being dimmed #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 1 commit into from
Jul 27, 2026
Merged

fix(core): prevent popup dock icons from being dimmed #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/core/src/client/webcomponents/components/dock/DockEntries.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ import { sharedStateToRef } from '../../state/docks'
import DockEntry from './DockEntry.vue'
import DockGroupButton from './DockGroupButton.vue'

const props = defineProps<{
const props = withDefaults(defineProps<{
context: DocksContext
entries: DevToolsDockEntry[]
selected: DevToolsDockEntry | null
isVertical: boolean
}>()
dimInactive?: boolean
}>(), {
dimInactive: true,
})

const emit = defineEmits<{
(e: 'select', entry: DevToolsDockEntry): void
Expand Down Expand Up @@ -62,6 +65,7 @@ function toggleDockEntry(dock: DevToolsDockEntry) {
:group="dock"
:is-vertical="isVertical"
:selected="selected"
:dim-inactive="dimInactive"
@select="(e) => emit('select', e)"
/>
<DockEntry
Expand All @@ -70,7 +74,7 @@ function toggleDockEntry(dock: DevToolsDockEntry) {
:dock
:is-action="dock.type === 'action'"
:is-selected="selected?.id === dock.id"
:is-dimmed="selected ? (selected.id !== dock.id) : false"
:is-dimmed="dimInactive && selected ? (selected.id !== dock.id) : false"
:is-vertical="isVertical"
:badge="dock.badge"
@click="toggleDockEntry(dock)"
Expand Down
3 changes: 3 additions & 0 deletions packages/core/src/client/webcomponents/components/dock/DockEntriesWithCategories.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ withDefaults(defineProps<{
selected: DevToolsDockEntry | null
isVertical: boolean
rotate?: boolean
dimInactive?: boolean
}>(), {
rotate: true,
dimInactive: true,
})

const emit = defineEmits<{
Expand All @@ -29,6 +31,7 @@ const emit = defineEmits<{
:entries="entries"
:is-vertical="isVertical && rotate"
:selected="selected"
:dim-inactive="dimInactive"
@select="(e) => emit('select', e)"
/>
</template>
Expand Down
9 changes: 6 additions & 3 deletions packages/core/src/client/webcomponents/components/dock/DockGroupButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,15 @@ import { setDocksGroupPanel, useDocksGroupPanel } from '../../state/floating-too
import DockEntry from './DockEntry.vue'
import DockGroupPopover from './DockGroupPopover.vue'

const props = defineProps<{
const props = withDefaults(defineProps<{
context: DocksContext
group: DevToolsViewGroup
isVertical: boolean
selected: DevToolsDockEntry | null
}>()
dimInactive?: boolean
}>(), {
dimInactive: true,
})

const emit = defineEmits<{
(e: 'select', entry: DevToolsDockEntry): void
Expand Down Expand Up @@ -122,7 +125,7 @@ function onClick() {
:dock="group"
:is-vertical="isVertical"
:is-selected="isActive || isPanelVisible"
:is-dimmed="selected ? !isActive : false"
:is-dimmed="dimInactive && selected ? !isActive : false"
:badge="group.badge"
@click="onClick"
/>
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/client/webcomponents/components/dock/DockStandalone.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ function switchEntry(id: string | undefined) {
:groups="groupedEntries"
:is-vertical="false"
:selected="context.docks.selected"
:dim-inactive="false"
@select="(e) => switchEntry(e?.id)"
>
<template #separator>
Expand Down
Loading