Skip to content

fix(core): scroll selected command palette item into view inside shad… #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 1 commit into from
Jul 24, 2026
Merged

fix(core): scroll selected command palette item into view inside shad… #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/src/client/webcomponents/components/command-palette/CommandPalette.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const show = computed({
const search = ref('')
const selectedIndex = ref(0)
const searchInput = useTemplateRef<HTMLInputElement>('searchInput')
const listContainer = useTemplateRef<HTMLElement>('listContainer')
const visible = ref(false)

// Breadcrumb stack for sub-command drill-down
Expand Down Expand Up @@ -113,7 +114,8 @@ function scrollToItem() {
const item = filtered.value[selectedIndex.value]
if (!item)
return
const el = document.getElementById(`cmd-${item.entry.id}`)
const root = listContainer.value?.getRootNode() as ShadowRoot | Document | undefined
const el = root?.getElementById(`cmd-${item.entry.id}`)
el?.scrollIntoView({ block: 'nearest' })
}

Expand Down Expand Up @@ -289,7 +291,7 @@ function getKeybindings(id: string) {
</header>

<!-- Items -->
<div class="flex-1 of-y-auto p-1.5">
<div ref="listContainer" class="flex-1 of-y-auto p-1.5">
<CommandPaletteItem
v-for="(item, idx) of filtered"
:key="item.entry.id"
Expand Down
Loading