Added handling for responseType 'LOAD_CANCELLED'#131
Open
cweitkamp wants to merge 2 commits intovitalidze:masterfrom
Open
Added handling for responseType 'LOAD_CANCELLED'#131cweitkamp wants to merge 2 commits intovitalidze:masterfrom
cweitkamp wants to merge 2 commits intovitalidze:masterfrom
Conversation
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
vitalidze
reviewed
Nov 20, 2020
Owner
vitalidze
left a comment
vitalidze
left a comment
There was a problem hiding this comment.
Thank you for the PR. When do you receive such message?
Also, do you mind if I ask you to write unit-test(s) for this case?
| StandardResponse.Invalid invalid = (StandardResponse.Invalid) response; | ||
| throw new ChromeCastException("Invalid request: " + invalid.reason); | ||
| } else if (response instanceof StandardResponse.LoadFailed) { | ||
| } else if (response instanceof StandardResponse.LoadCancelled || response instanceof StandardResponse.LoadFailed) { |
Owner
There was a problem hiding this comment.
I think it should fall under the different if branch, throwing an error saying that the Load was cancelled. However I am not sure about the use case.
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Contributor
Author
This warning has been reported in our community: https://community.openhab.org/t/getting-error-playing-mp3-thru-google-assistant/98420
In general I would do it but I am afraid my time is very limited at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents warnings like these:
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de