Skip to content

Conversation

@alekzvik
Copy link
Collaborator

@alekzvik alekzvik commented Dec 3, 2024

Continuation of #3168
Start of perf testing of two different las versions.
I've added a bench to load the .laz file from the test folder.

I am having problems running it locally, yarn test bench fails on the parquet bench, and yarn test bench-browser does not run the bench at all, running tests in the browser instead. Do you run bench often? Is it possible that it is broken? Or is it a local setup issue?

@ibgreen
Copy link
Collaborator

ibgreen commented Jan 5, 2025

@alekzvik Thanks for putting this PR up! Sorry for the slow reply, I've been out of office.

I am having problems running bench locally yarn test bench-browser does not run the bench at all, running tests in the browser instead.

Yes, I get the same failure. Which tests are run for different yarn test entrypoints should be controlled by https://github.com/visgl/loaders.gl/blob/master/.ocularrc.js#L47 but it doesn't seem to work, though strangely yarn test bench does seem to work.

@Pessimistress any thoughts.

yarn test bench fails on the parquet bench,

We can disable the parquet bench for now, however even when I do, none of the tests seem to generate output for me.

Do you run bench often? Is it possible that it is broken? Or is it a local setup issue?

No, we run it a lot when we optimize, then we don't run it for long whiles so it can break. We should probably add yarn test bench to CI, to catch breakages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants