Example of open vioserial by port_id #1395
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @asssh52, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the efficiency and clarity of how vioserial devices are identified and opened. By leveraging the port_id embedded within the device path, the application can now directly locate and connect to the desired serial port, avoiding unnecessary enumeration and information queries on other devices. This change streamlines the device initialization process and improves overall performance.
Highlights
- Direct Port ID Lookup: The core logic for finding
vioserialdevices has been refactored to directly search for a device by itsport_idrather than iterating through all available devices and querying each one. This is achieved by parsing theport_iddirectly from the device'sDevicePathstring. - Improved Device Enumeration: The
GetDevicePathfunction now iterates through device interfaces, extracts theport_idusing regular expressions, and returns the device path only for the matching ID. This eliminates the need forIOCTL_GET_INFORMATIONcalls on unrelated ports, making the process more efficient. - Code Modernization and Cleanup: Introduced C++ standard library components like
std::string,std::regex, andstd::vectorfor more robust string manipulation and dynamic buffer management. Windows API headers were moved to the.cppfile for better encapsulation, and constants likeLOOKUP_PORT_MAXwere introduced for loop bounds.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
[Jenkins CI]: Can one of the admins verify this patch? |
There was a problem hiding this comment.
Code Review
This pull request refactors the device discovery logic to open a vio-serial port by its ID directly, which is a nice improvement. The change correctly uses std::vector to manage the device path buffer, fixing a memory leak from the previous implementation.
I've identified a resource leak where the HDEVINFO handle is not always released, a potential crash due to an unhandled exception from std::stoi, an incorrect format specifier in a wprintf call, and a duplicated constant between two files.
|
ok to test |
|
ok to test |
asssh52
force-pushed
the
master
branch
3 times, most recently
from
388e568 to
db02ab6
Compare
|
ok to test |
asssh52
force-pushed
the
master
branch
3 times, most recently
from
82974bd to
2e321b8
Compare
|
rerun tests |
Allow open vio-serial port by it's PORT_ID, without calling CreateFile() and IOCTL_GET_INFORMATION for unrelated ports. We can do this, because DevicePath component from SetupDiGetInterfaceDetail already has the port_id part and we can find DevicePath for needed port_id at once. Signed-off-by: Artem Galaburda <[email protected]>
|
rerun tests |
|
@asssh52 please fix compilation errors. |
3 participants
This change demonstrates how to open vio-serial port by it's ID without calling CreateFile() and IOCTL_GET_INFORMATION for unrelated ports.
We can do this, because DevicePath component from SetupDiGetInterfaceDetail already has the port_id part and we can find DevicePath for needed port_id at once.