[CI-NO-BUILD] [vioscsi] Programmatically determine max_segments #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Waiting on PR #1216 to merge before rebasing and review. |
benyamin-codez
force-pushed
the
vioscsi-max-segments
branch
from
7fe7d16 to
dee96e0
Compare
benyamin-codez
changed the title
benyamin-codez
force-pushed
the
vioscsi-max-segments
branch
2 times, most recently
from
ff55a74 to
3e61c4f
Compare
Refactors VioScsiFindAdapter() to:
1. Use new mnemonic adaptExt->max_segments to replace adaptExt->max_physical_breaks
(also used in the VioScsiBuildIo() and VioScsiReadExtendedData() functions)
2. Enable Registry lookup for max_segments in neo value "MaxPhysicalSegments" or
the legacy value "PhysicalBreaks". New value defined by REGISTRY_MAX_PH_SEGMENTS.
3. Also derive max_segments from adaptExt->scsi_config.seg_max and also from
the adaptExt->scsi_config.max_sectors value
4. Choose from among best candidates and check within limits
5. Enforce legacy StorPort NOPB off-by-one behaviour and provide explanation
6. Improves relevant instrumentation
7. Use new mnemonic PHYS_SEGMENTS_LIMIT to replace MAX_PHYS_SEGMENTS
8. Update VIRTIO_MAX_SG to (PHYS_SEGMENTS_LIMIT + 1)
9. Update VIRTIO_SCSI_QUEUE_LAST to (MAX_CPU - VIRTIO_SCSI_REQUEST_QUEUE_0)
10. Removed max_segments increment from calculation of sgMaxElements in VioScsiBuildIo()
Note: This commit enables the use of max_segments greater than
adaptExt->scsi_config.seg_max (max = 254) up to
PHYS_SEGMENTS_LIMIT (presently 512).
Signed-off-by: benyamin-codez <[email protected]>
benyamin-codez
force-pushed
the
vioscsi-max-segments
branch
from
3e61c4f to
0ceddd8
Compare
Collaborator
|
[Jenkins CI]: Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
VioScsiFindAdapter()to:adaptExt->max_segmentsto replaceadaptExt->max_physical_breaks(also used in theVioScsiBuildIo()andVioScsiReadExtendedData()functions)max_segmentsin neo value "MaxPhysicalSegments" or the legacy value "PhysicalBreaks". New value defined byREGISTRY_MAX_PH_SEGMENTS.max_segmentsfromadaptExt->scsi_config.seg_maxand from theadaptExt->scsi_config.max_sectorsvaluePHYS_SEGMENTS_LIMITto replaceMAX_PHYS_SEGMENTSVIRTIO_MAX_SGto(PHYS_SEGMENTS_LIMIT + 1)VIRTIO_SCSI_QUEUE_LASTto(MAX_CPU - VIRTIO_SCSI_REQUEST_QUEUE_0)max_segmentsincrement from calculation ofsgMaxElementsinVioScsiBuildIo()Note: This commit enables the use of max_segments greater than
adaptExt->scsi_config.seg_max(max = 254) up toPHYS_SEGMENTS_LIMIT(presently 512). PR #1316 increases this value to 1,022.