Skip to content

[CI-NO-BUILD] [viostor] Refactor RhelSetGuestFeatures() #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[CI-NO-BUILD] [viostor] Refactor RhelSetGuestFeatures() #1302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 61 additions & 3 deletions viostor/virtio_stor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,12 +652,70 @@ VOID RhelSetGuestFeatures(IN PVOID DeviceExtension)
guestFeatures |= (1ULL << VIRTIO_F_ORDER_PLATFORM);
}

RhelDbgPrint(TRACE_LEVEL_VERBOSE,
" Host Features : %llu | Guest Features : %llu\n",
adaptExt->features,
guestFeatures);
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_F_VERSION_1 flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_F_VERSION_1)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_F_RING_PACKED flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_F_RING_PACKED)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_F_ANY_LAYOUT flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_F_ANY_LAYOUT)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_F_ACCESS_PLATFORM flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_F_ACCESS_PLATFORM)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_RING_F_EVENT_IDX flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_RING_F_EVENT_IDX)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_RING_F_INDIRECT_DESC flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_RING_F_INDIRECT_DESC)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_BLK_F_FLUSH flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_BLK_F_FLUSH)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_BLK_F_BARRIER flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_BLK_F_BARRIER)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_BLK_F_RO flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_BLK_F_RO)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_BLK_F_SIZE_MAX flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_BLK_F_SIZE_MAX)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_BLK_F_SEG_MAX flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_BLK_F_SEG_MAX)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_BLK_F_BLK_SIZE flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_BLK_F_BLK_SIZE)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_BLK_F_GEOMETRY flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_BLK_F_GEOMETRY)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_BLK_F_MQ flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_BLK_F_MQ)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_BLK_F_DISCARD flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_BLK_F_DISCARD)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_BLK_F_WRITE_ZEROES flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_BLK_F_WRITE_ZEROES)) ? "ON" : "OFF");
RhelDbgPrint(TRACE_GUEST_FEATURES,
" VIRTIO_F_ORDER_PLATFORM flag is : %s \n",
(guestFeatures & (1ULL << VIRTIO_F_ORDER_PLATFORM)) ? "ON" : "OFF");

if (!NT_SUCCESS(virtio_set_features(&adaptExt->vdev, guestFeatures)))
{
RhelDbgPrint(TRACE_LEVEL_FATAL, " virtio_set_features failed\n");
return;
RhelDbgPrint(TRACE_LEVEL_WARNING, " virtio_set_features() FAILED...!!!\n");
}
else
{
RhelDbgPrint(TRACE_GUEST_FEATURES, " virtio_set_features() executed successfully.\n");
}
RhelDbgPrint(TRACE_LEVEL_VERBOSE, " Host Features %llu gust features %llu\n", adaptExt->features, guestFeatures);
}

BOOLEAN
Expand Down
2 changes: 2 additions & 0 deletions viostor/virtio_stor_trace.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ extern int nViostorDebugLevel;
WPP_DEFINE_BIT(TRACE_LEVEL_WARNING) /* bit 3 = 0x00000008 */ \
WPP_DEFINE_BIT(TRACE_LEVEL_INFORMATION) /* bit 4 = 0x00000010 */ \
WPP_DEFINE_BIT(TRACE_LEVEL_VERBOSE) /* bit 5 = 0x00000020 */ \
WPP_DEFINE_BIT(TRACE_REGISTRY) /* bit 6 = 0x00000040 */ \
WPP_DEFINE_BIT(TRACE_GUEST_FEATURES) /* bit 7 = 0x00000080 */ \
)

#define WPP_Flags_LEVEL_LOGGER(Flags, level) \
Expand Down